GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Handle bad paths in `sys.path` by lostmsu · Pull Request #2383 · pythonnet/pythonnet

Conversation

@lostmsu

@lostmsu lostmsu commented May 10, 2024

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

User can add arbitrary strings to sys.path. When we probe for assemblies in sys.path the ones that were not valid paths caused the probing to fail, never reaching the valid ones that actually had the desired assembly.

This change handles these cases by generating a warning and continuing to probe in other directories.

Does this close any currently open issues?

fixes #2376

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Updated the CHANGELOG

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lostmsu
lostmsu force-pushed the bugs/sys.path-invalid branch 3 times, most recently from 3b2958b to eef9619 Compare May 10, 2024 22:23
@lostmsu
handle bad paths in sys.path
eb61851 
fixes pythonnet#2376
@lostmsu
lostmsu force-pushed the bugs/sys.path-invalid branch from eef9619 to eb61851 Compare May 10, 2024 22:32
filmor
filmor approved these changes May 11, 2024
View reviewed changes
@filmor
filmor merged commit b112885 into pythonnet:master May 11, 2024
@filmor filmor mentioned this pull request Oct 11, 2024
AssemblyManager.FindAssemblyCandidates runs without GIL and crashes with "Attempted to read or write protected memory" unpredictably #2481
Open
@dependabot dependabot Bot mentioned this pull request Jan 16, 2026
Bump pythonnet from 3.0.3 to 3.0.5 mattemangia/Deep3DStudio#99
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filmor filmor filmor approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System.ArgumentException: Illegal characters in path

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lostmsu @filmor
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.