GeezerVison is showing github.com — Python exception raised on conversion failure by macaronikazoo · Pull Request #2741 · pythonnet/pythonnet
Conversation
What does this implement/fix? Explain your changes.
Converting a CLR value to Python can throw after the call has succeeded, eg if an encoder's TryEncode throws, or if calling enumerator.Current throws. Previously the exception was never converted to a Python exception making it uncatchable even instead, so Python code could not catch it, not even using except BaseException
- MethodBinder.Invoke guarded only the invocation, and converted the result and out parameters after its try/catch
- Iterator.tp_iternext guarded MoveNext but not Current or the conversion of the item
- ArrayObject indexing converted items with no guard at all
Each now reports the failure through Exceptions.SetError, as the existing catch already does for the call itself. Property and field getters already convert inside their try and are unchanged.
Checklist
Check all those that are applicable and complete.
- Make sure to include one or more tests for your change
- [n/a] If an enhancement PR, please create docs and at best an example
- Ensure you have signed the .NET Foundation CLA
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Converting a CLR value to Python can throw after the call has
succeeded, eg if an encoder's TryEncode throws, or if calling
enumerator.Current throws. Previously the exception was never
converted to a Python exception making it uncatchable even
instead, so Python code could not catch it, not even using
except BaseException
- MethodBinder.Invoke guarded only the invocation, and converted the
result and out parameters after its try/catch
- Iterator.tp_iternext guarded MoveNext but not Current or the
conversion of the item
- ArrayObject indexing converted items with no guard at all
Each now reports the failure through Exceptions.SetError, as the
existing catch already does for the call itself. Property and field
getters already convert inside their try and are unchanged.
|
Thanks a lot. If all is well, I will merge this and release an rc2 today.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
ok no worries - I have another one that I'll create shortly... related to disallowing certain .net types to be handed over to python
|
filmor reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
however, the other change I want to submit builds off this one - but this one seemed useful in an of itself, so I submitted it separately. should I wait for this one to be accepted before submitting the other PR?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Just go ahead. I won't have time before afternoon for a proper review.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Oct 4, 2026
This was referenced Oct 11, 2026
|
This is not the right fix for the issue as it spreads to other paths.
There's only one call site for TryEncode:
|
var encoded = PyObjectConversions.TryEncode(value, type); |
Why wasn't it modified?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
filmor
filmor approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|