GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Align DocBlock Promise return types by WyriHaximus · Pull Request #44 · reactphp/cache

Conversation

@WyriHaximus

@WyriHaximus WyriHaximus commented Feb 1, 2021

Copy link
Copy Markdown
Member

Currently most of the docblocks provide a return type inside the
PromiseInterface like bool or array. This commit aligns it for all
methods on the interface.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@WyriHaximus
Align DocBlock Promise return types
f55ee41 
Currently most of the docblocks provide a return type inside the
PromiseInterface like bool or array. This commit aligns it for all
methods on the interface.
@WyriHaximus WyriHaximus added maintenance easy pick labels Feb 1, 2021
@WyriHaximus WyriHaximus added this to the v1.1.1 milestone Feb 1, 2021
@WyriHaximus
WyriHaximus requested review from clue and jsor February 1, 2021 15:43
jsor
jsor approved these changes Feb 1, 2021
View reviewed changes
clue
clue approved these changes Feb 2, 2021
View reviewed changes

@clue clue left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Thanks for the update, changes LGTM! :shipit:

Good to see this is now in line with the README introduced with #34.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clue
clue merged commit 4bf736a into reactphp:master Feb 2, 2021
@WyriHaximus
WyriHaximus deleted the align-docblock-promise-return-types branch February 2, 2021 08:41
@clue clue mentioned this pull request May 21, 2024
Add PHPStan to test environment with max level #61
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes
@clue clue clue approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

easy pick maintenance

Projects

None yet

Milestone

v1.1.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@WyriHaximus @jsor @clue
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.