GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Issue 133 Headings in templates & guide should be sentence case by emmurphy1 · Pull Request #189 · redhat-documentation/modular-docs

Conversation

@emmurphy1

@emmurphy1 emmurphy1 commented Mar 25, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Emily Murphy added 3 commits March 25, 2022 11:22
Emily Murphy
issue-133 updated sentence case
0cdfb28
Emily Murphy
issue-133 updated subheadings to title case
c618130
Emily Murphy
issue-133 updated subheadings to title case
16f4f8c
@emmurphy1
emmurphy1 requested a review from a team as a code owner March 25, 2022 16:09
@emmurphy1 emmurphy1 mentioned this pull request Mar 25, 2022
Headings in templates & guide should be sentence case #133
Closed
sterobin
sterobin approved these changes Mar 25, 2022
View reviewed changes

@sterobin sterobin left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaay! Thank you so much, @emmurphy1 So glad we finally broke down and got that addressed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mjahoda
mjahoda reviewed Mar 28, 2022
View reviewed changes
Comment thread modular-docs-manual/content/topics/module_auditing.adoc Resolved

Uh oh!

There was an error while loading. Please reload this page.
mjahoda
mjahoda approved these changes Mar 28, 2022
View reviewed changes

@mjahoda mjahoda left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for one omission (I put a comment inline), it looks great to me. Thank you for this significant and long-term postponed change!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Emily Murphy
issue-133 updated Auditing your feature-based manual heading
8573bad
@vsodhi

vsodhi commented Apr 13, 2022

Copy link
Copy Markdown

LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emmurphy1
emmurphy1 merged commit 1afdb2a into master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjahoda mjahoda mjahoda approved these changes
+1 more reviewer
@sterobin sterobin sterobin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@emmurphy1 @vsodhi @mjahoda @sterobin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.