GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — issue-203 Change :_content-type: to :_mod-docs-content-type: by emmurphy1 · Pull Request #209 · redhat-documentation/modular-docs

Conversation

@emmurphy1

@emmurphy1 emmurphy1 commented Jul 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

I simply changed the variable name without explanation. After we merge this change, we will send out a detailed email explaining the reason for the change and options for updating repos that use this variable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@emmurphy1
issue-203 changed :_content-type: to :_mod-docs-content-type:
70781a9
@emmurphy1
emmurphy1 requested a review from a team as a code owner July 17, 2023 13:20
ncbaratta
ncbaratta approved these changes Jul 17, 2023
View reviewed changes

@ncbaratta ncbaratta left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
abhatt-rh
abhatt-rh approved these changes Jul 17, 2023
View reviewed changes

@abhatt-rh abhatt-rh left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Jenny-Anne

Jenny-Anne commented Jul 17, 2023

Copy link
Copy Markdown
Collaborator

lgtm too
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abhatt-rh

abhatt-rh commented Jul 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

lgtm too

Hey @Jenny-Anne To record your approval (indicated by green check mark) for the PR, click Files changed > Review changes > Approve > Submit review. HTH!
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Jenny-Anne
Jenny-Anne approved these changes Jul 17, 2023
View reviewed changes
IanFrangs
IanFrangs approved these changes Jul 17, 2023
View reviewed changes

@IanFrangs IanFrangs left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@neal-timpe
neal-timpe self-requested a review July 20, 2023 15:43
neal-timpe
neal-timpe approved these changes Jul 20, 2023
View reviewed changes
thatdocslady
thatdocslady approved these changes Jul 21, 2023
View reviewed changes
@gbrinn

gbrinn commented Jul 21, 2023

Copy link
Copy Markdown
Collaborator

lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mjahoda
mjahoda approved these changes Jul 21, 2023
View reviewed changes
@emmurphy1
emmurphy1 merged commit 9f87622 into main Aug 1, 2023
This was referenced Oct 11, 2023
Modular docs should have versioned releases #127
Closed
Changing the module context rule as it doesn't highlight anything in VS Code redhat-documentation/vale-at-red-hat#658
Closed
@rolfedh

rolfedh commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

Fixes #203
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rolfedh rolfedh mentioned this pull request Nov 27, 2023
Fix metadata in templates from content_type to module_type #203
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatdocslady thatdocslady thatdocslady approved these changes
@neal-timpe neal-timpe neal-timpe approved these changes
@mjahoda mjahoda mjahoda approved these changes
@abhatt-rh abhatt-rh abhatt-rh approved these changes
@Jenny-Anne Jenny-Anne Jenny-Anne approved these changes
@IanFrangs IanFrangs IanFrangs approved these changes
+1 more reviewer
@ncbaratta ncbaratta ncbaratta approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@emmurphy1 @Jenny-Anne @abhatt-rh @gbrinn @rolfedh @ncbaratta @thatdocslady @neal-timpe @mjahoda @IanFrangs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.