GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Warn before using two consecutive Additional resources by mjahoda · Pull Request #210 · redhat-documentation/modular-docs

Conversation

@mjahoda

@mjahoda mjahoda commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

#193

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mjahoda
Warn before using two consecutive Additional resources
800f417 
#193
@mjahoda
mjahoda requested a review from a team as a code owner August 10, 2023 19:35
ncbaratta
ncbaratta approved these changes Aug 14, 2023
View reviewed changes
emmurphy1
emmurphy1 approved these changes Sep 12, 2023
View reviewed changes
Jenny-Anne
Jenny-Anne approved these changes Sep 12, 2023
View reviewed changes

@Jenny-Anne Jenny-Anne left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Mirek, thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
abhatt-rh
abhatt-rh approved these changes Sep 13, 2023
View reviewed changes
rolfedh
rolfedh approved these changes Sep 13, 2023
View reviewed changes

@rolfedh rolfedh left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
neal-timpe
neal-timpe approved these changes Sep 13, 2023
View reviewed changes
@mjahoda
mjahoda merged commit 3d4c3ac into main Sep 13, 2023
@mjahoda mjahoda mentioned this pull request Sep 13, 2023
Removing or discouraging Additional resources in assemblies #193
Closed
@mjahoda
mjahoda deleted the issue-193 branch October 11, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfedh rolfedh rolfedh approved these changes
@neal-timpe neal-timpe neal-timpe approved these changes
@emmurphy1 emmurphy1 emmurphy1 approved these changes
@abhatt-rh abhatt-rh abhatt-rh approved these changes
@Jenny-Anne Jenny-Anne Jenny-Anne approved these changes
+1 more reviewer
@ncbaratta ncbaratta ncbaratta approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@mjahoda @ncbaratta @rolfedh @neal-timpe @emmurphy1 @abhatt-rh @Jenny-Anne
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.