GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: simplify types treating key and payload always as optional by Swiftwork · Pull Request #380 · reflagcom/javascript

Conversation

@Swiftwork

@Swiftwork Swiftwork commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Utilizing TypeScript intersection to simplify config types. Config keys and payload can now always be undefined.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Swiftwork
feat: simplify types treating key and payload always as optional
0fc4d9d
@Swiftwork Swiftwork added the bug Something isn't working label Mar 19, 2025
@Swiftwork
Swiftwork requested review from matus-vacula and roncohen March 19, 2025 14:31
@Swiftwork Swiftwork self-assigned this Mar 19, 2025
matus-vacula
matus-vacula approved these changes Mar 19, 2025
View reviewed changes
@Swiftwork
Swiftwork merged commit 2fa4704 into main Mar 20, 2025
@Swiftwork
Swiftwork deleted the buc-3437-usefeature-returns-different-type-than-its-return-type branch March 20, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roncohen roncohen Awaiting requested review from roncohen
1 more reviewer
@matus-vacula matus-vacula matus-vacula approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Swiftwork Swiftwork

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Swiftwork @matus-vacula
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.