GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||
GeezerVison is showing github.com — Upgrade to react-native 0.85, Animated improvements, missing APIs and props by Freddy03h · Pull Request #857 · rescript-react-native/rescript-react-native Conversation
Member
Upgrade the bindings to React Native 0.85
Animated
Fixes
New APIs and globals
New props
Deprecations
Notes for reviewers
🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions- remove StyleSheet.absoluteFillObject (removed upstream) - add Animated.useAnimatedValueXY and Animated.useAnimatedColor - add EventEmitter module - add selection to TextInput.ChangeEvent payload - add onPressMove prop to Pressable - add scrollsChildToFocus android prop to ScrollView Co-Authored-By: Claude Opus 5.5 <[email protected]> …on, optional parallel config - Color listener/stopAnimation/resetAnimation callbacks receive a color string - fix StyleProp.color returning Animated.Color.t instead of Color.t - add StyleProp.animatedColor - unify Color.create(~initialValue=?, ~config=?) with Color.input, Color.setValue takes input - add ~config to Value.create and ValueXY.create, add ValueXY.createFromValues - add Timing/Spring fromInterpolation - add hasListeners, attachNativeEvent, forkEvent, unforkEvent - parallel takes an optional ~config Co-Authored-By: Claude Opus 5.5 <[email protected]> hsla() produced `hsl(h, s%, l%, a)`, which React Native's color parser rejects. Co-Authored-By: Claude Opus 5.5 <[email protected]> …nctions timing, spring, decay, start, stop, reset and Value.interpolate were `let` aliases of externals, compiled to wrapper functions. Co-Authored-By: Claude Opus 5.5 <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]> …Image props, fix StickyHeaderComponent type - View: touch events, onFocusCapture/onBlurCapture, nextFocus* (Android), experimental_accessibilityOrder - Pressable: cancelable - TouchableWithoutFeedback: rejectResponderTermination - TextInput: inputAccessoryViewButtonLabel - Image: src - ScrollView: StickyHeaderComponent is a component, not an element (+ Animated.Value.fromStickyHeaderScrollValue) Co-Authored-By: Claude Opus 5.5 <[email protected]> …precate InteractionManager - InteractionManager is deprecated by React Native; runAfterInteractions returns a cancellable task Co-Authored-By: Claude Opus 5.5 <[email protected]> - aria-busy, aria-checked (true/false/mixed), aria-disabled, aria-expanded, aria-hidden, aria-label, aria-selected, aria-value*, aria-modal (iOS), aria-labelledby and aria-live (Android) - fontVariant: ligatures, contextual and stylistic-one..twenty Co-Authored-By: Claude Opus 5.5 <[email protected]> - ProgressBarAndroid, Clipboard (extracted from core) - StatusBar.setNetworkActivityIndicatorVisible - TextInput blurOnSubmit, hasTVPreferredFocus on Button/TouchableHighlight/ TouchableOpacity Co-Authored-By: Claude Opus 5.5 <[email protected]> …orUtils - Global: requestIdleCallback / cancelIdleCallback, setImmediate / clearImmediate, queueMicrotask - ErrorUtils: setGlobalHandler, getGlobalHandler, reportError, reportFatalError - InteractionManager deprecation points to Global.requestIdleCallback Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: a65d9cf49d
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| referrerPolicy?: referrerPolicy, | ||
| resizeMode?: Style.resizeMode, | ||
| source: Source.t, | ||
| src?: string, |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Make source optional when using src
Adding src does not make the new API usable by itself because source remains a required field immediately above. A valid React Native <Image src="…" /> therefore fails ReScript type-checking unless callers also provide a redundant source; make source optional so either image-source prop can be used.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Matches React Native, where source is optional (source?: ImageSource). Co-Authored-By: Claude Opus 5.5 <[email protected]>
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.