GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(language-server): add python variable line for robot goto by leojuurinen-vala · Pull Request #539 · robotcodedev/robotcode

Conversation

@leojuurinen-vala

@leojuurinen-vala leojuurinen-vala commented Dec 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Add parsing of the variables from python files to include their line for navigation from robot.

Root Cause:
Python variables imported from .py files had hardcoded line_no=1, col_offset=0, causing go-to-definition to always jump to the beginning of the file instead of the actual variable definition line.

Solution:
Added AST-based line number extraction that parses Python source files to find the actual line numbers and column offsets where variables are defined. Support for RF >= 7.0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@leojuurinen-vala
leojuurinen-vala marked this pull request as draft December 1, 2025 19:52
@leojuurinen-vala
leojuurinen-vala marked this pull request as ready for review December 1, 2025 20:02
@leojuurinen-vala

leojuurinen-vala commented Dec 3, 2025

Copy link
Copy Markdown
Author

@d-biehl Do you think this is something to consider? Does it seem good for you, not sure if would require any other updates else where? Been testing it and it seems to work, but this is first change I have done for a VSCode plugin, so might be missing something.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@d-biehl

d-biehl commented Dec 14, 2025

Copy link
Copy Markdown
Member

At first glance this looks nice, but I need to take a closer look at it again — it’s Christmas and there’s just so much going on right now…

Also, for security reasons you should sign your commits — see the CONTRIBUTION.md guides for more information. I won’t just merge unsigned code so easily… hope you understand ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@leojuurinen-vala

leojuurinen-vala commented Dec 15, 2025

Copy link
Copy Markdown
Author

It is a busy season, hope all goes well and merry :).
That part I missed, I will try fixing the signings.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Leo and others added 2 commits January 9, 2026 09:44
Leo @leojuurinen-vala
feat(language-server): add python variable line for robot goto
48f2274 
Add parsing of the variables from python files to include their line for navigation from robot.
@leojuurinen-vala
Revert exception handling extending the offset
5d9de5e
@leojuurinen-vala
leojuurinen-vala force-pushed the feature/variable_line_numbers branch from 81be7cf to 5d9de5e Compare January 9, 2026 07:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@leojuurinen-vala @d-biehl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.