GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — Fix enum parsing bug regarding decimal digit characters by stephen-hansen · Pull Request #79 · robotpy/robotpy-cppheaderparser Conversation
Contributor
Currently if I have an enum of the form enum Foobar { A_t = 9, B_t = '9' }; CppHeaderParser will parse out the enum values as [
{"name": "A_t", "value": 9},
{"name": "B_t", "value": 9}
]Clearly this is wrong, the enum values should be [
{"name": "A_t", "value": 9},
{"name": "B_t", "raw_value": "9", "value": 57}
]where B_t represents the Unicode value for the character "9" (and not the actual integer value 9). This PR includes the changes necessary to fix the enum parse logic. I've also updated a unit test to check this case and it passes with these changes.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |