GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update to Python 3.6 and different encodings by MatthiasJobst · Pull Request #1 · rootsdev/python-gedcom-parser

Conversation

@MatthiasJobst

@MatthiasJobst MatthiasJobst commented Jul 16, 2017

Copy link
Copy Markdown

Hi,
in an effort to use the python library I updated the code to Python 3.6. Further I made some modifications to handle different date and file formats or encodings.

Your work has been a great help and I hope those changes help more people.

Regards,
Matthias

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MatthiasJobst added 2 commits July 15, 2017 08:28
@MatthiasJobst
Upgrade to python 3.6
df10fc1
@MatthiasJobst
Some refactoring to handle format and encoding issues
02cf858 
Gedcom takes an iterator of lines instead of a file directly. This allows to apply encoding.
Date is a file that delivers a splitDate function to handle the special cases encountered when splitting dates.
Added Query class to split concerns between storage and query.
bean5
bean5 suggested changes May 6, 2024
View reviewed changes

@bean5 bean5 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only saw 1 thing that seemed out of place here and requesting changes as a result.

Note: I did not run the code.

CC @zappala

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test.py
marriage=1857,marriage_start=1850,marriage_end=1860,
family_surname='Nicotra',family_given='Maria',
criteria='surname=N:birthrange=1820-1840:deathrange=1900-1910'):
birth=1968,birth_start=1940,birth_end=1960,

@bean5 bean5 May 6, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthiasJobst These changes seem to be opinionated and outside the scope of upgrading to a newer version of Python. A quick, cursory review of the other changes did not stand out as out of scope to me.

CC: @zappala

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bean5 bean5 bean5 requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MatthiasJobst @bean5
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.