GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — revert: correlate business spans with active observability trace (#465) by NiteshDhanpal · Pull Request #472 · scaleapi/scale-agentex-python Conversation
|
| Filename | Overview |
|---|---|
| src/agentex/lib/core/tracing/obs_ids.py | File fully deleted — removes get_obs_mode(), obs_correlation(), _lgtm_ids(), and _ddtrace_ids() with no remaining references in the codebase. |
| src/agentex/lib/core/tracing/trace.py | Removes the obs_correlation import and its call sites in both Trace.start_span() and AsyncTrace.start_span(); no dangling references remain. |
sequenceDiagram
participant Caller
participant Trace/AsyncTrace
participant obs_ids (removed)
participant Span
Note over Trace/AsyncTrace,obs_ids (removed): Before revert (PR #465)
Caller->>Trace/AsyncTrace: start_span(name, input, data)
Trace/AsyncTrace->>obs_ids (removed): obs_correlation()
obs_ids (removed)-->>Trace/AsyncTrace: {"obs.trace_id": ..., "obs.span_id": ...}
Trace/AsyncTrace->>Span: create with merged data + obs tags
Note over Trace/AsyncTrace,obs_ids (removed): After revert (this PR)
Caller->>Trace/AsyncTrace: start_span(name, input, data)
Trace/AsyncTrace->>Span: create with serialized_data only
Reviews (1): Last reviewed commit: "revert: correlate business spans with ac..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Reverts #465 (src/agentex/lib/core/tracing/obs_ids.py and trace.py). The dependent open PRs #466/#467/#471 build on obs_ids and are intentionally left open for now. Co-Authored-By: Claude Opus 4.8 <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.