GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — revert: correlate business spans with active observability trace (#465) by NiteshDhanpal · Pull Request #472 · scaleapi/scale-agentex-python

Conversation

@NiteshDhanpal

@NiteshDhanpal NiteshDhanpal commented Jul 26, 2026 •
edited by greptile-apps Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Reverts #465 (merged squash commit c67e177).

What this removes

  • src/agentex/lib/core/tracing/obs_ids.py (get_obs_mode / obs_correlation / sync_ddtrace_to_lgtm)
  • the obs_correlation() tagging added to src/agentex/lib/core/tracing/trace.py

Stack note
#465 is the foundation of the obs stack; the dependent PRs #466 (W3C FastACP ingress), #467 (Temporal interceptor) and #471 (ddtrace dual-sync) import obs_ids / sync_ddtrace_to_lgtm. They are not merged to next, so nothing merged breaks — but they are now orphaned against next and left open intentionally, to be reworked or closed separately.

Why
Backing out the business-span ↔ observability-trace correlation approach pending the tracing-library redesign.

🤖 Generated with Claude Code

Greptile Summary

This PR reverts the business-span ↔ observability-trace correlation added in #465, removing obs_ids.py and the obs_correlation() call sites in both Trace and AsyncTrace. The revert is clean: no remaining imports or references to the deleted module exist anywhere in the merged next branch.

  • obs_ids.py deleted: removes get_obs_mode(), _lgtm_ids(), _ddtrace_ids(), and obs_correlation() entirely.
  • trace.py cleaned up: the import of obs_correlation and its two call sites (in Trace.start_span and AsyncTrace.start_span) are removed symmetrically; span creation reverts to using serialized_data without observability tag injection.

Confidence Score: 5/5

Safe to merge — this is a clean revert of two files with no surviving references to the deleted module on the target branch.

The deletion of obs_ids.py is complete and verified: no imports or call sites remain anywhere in src/. The two removal hunks in trace.py are symmetric (Trace and AsyncTrace treated identically), and the post-revert file reads correctly. Orphaned dependent PRs (#466, #467, #471) are explicitly unmerged and the description acknowledges them.

Files Needing Attention: No files require special attention.

Important Files Changed

Filename Overview
src/agentex/lib/core/tracing/obs_ids.py File fully deleted — removes get_obs_mode(), obs_correlation(), _lgtm_ids(), and _ddtrace_ids() with no remaining references in the codebase.
src/agentex/lib/core/tracing/trace.py Removes the obs_correlation import and its call sites in both Trace.start_span() and AsyncTrace.start_span(); no dangling references remain.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant Trace/AsyncTrace
    participant obs_ids (removed)
    participant Span

    Note over Trace/AsyncTrace,obs_ids (removed): Before revert (PR #465)
    Caller->>Trace/AsyncTrace: start_span(name, input, data)
    Trace/AsyncTrace->>obs_ids (removed): obs_correlation()
    obs_ids (removed)-->>Trace/AsyncTrace: {"obs.trace_id": ..., "obs.span_id": ...}
    Trace/AsyncTrace->>Span: create with merged data + obs tags

    Note over Trace/AsyncTrace,obs_ids (removed): After revert (this PR)
    Caller->>Trace/AsyncTrace: start_span(name, input, data)
    Trace/AsyncTrace->>Span: create with serialized_data only
Loading

Reviews (1): Last reviewed commit: "revert: correlate business spans with ac..." | Re-trigger Greptile

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@NiteshDhanpal @claude
revert: correlate business spans with active observability trace (#465)
94bc9ee
Reverts #465 (src/agentex/lib/core/tracing/obs_ids.py and trace.py). The dependent open PRs #466/#467/#471 build on obs_ids and are intentionally left open for now.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
@NiteshDhanpal NiteshDhanpal closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@NiteshDhanpal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.