GeezerVison is showing github.com — fix(deps): allow watchfiles 1.x so agentex-sdk installs on Python 3.14 by michaelxu2288 · Pull Request #511 · scaleapi/scale-agentex-python
Conversation
What
adk/pyproject.toml pins watchfiles>=0.24.0,<1.0. watchfiles 0.24.0 has no CPython 3.14 wheel, so uv tool install agentex-sdk on a 3.14 interpreter (Homebrew's default python3 today) falls back to a maturin source build and fails, although the package classifiers advertise 3.14. watchfiles 1.x publishes abi3 wheels that cover 3.14 and keeps the awatch API used in cli/handlers/run_handlers.py. Relax the pin to <2.0 and upgrade the locked release (uv lock --upgrade-package watchfiles, 0.24.0 -> 1.3.0). The uv.lock diff touches only the watchfiles entries.
Test
- Baseline, scratch venv on CPython 3.14.7:
uv pip install agentex-sdk fails building watchfiles 0.24.0.
- watchfiles 1.3.0 installs from its abi3 wheel and imports on CPython 3.14.7.
tests/lib/cli passes on 3.12 with watchfiles 1.3.0; ruff check clean.
Confidence Score: 5/5
The PR appears safe to merge, though the committed lock should be refreshed to match the package versions.
What we checked:
- Python 3.14 gets an old wheel: No. The lock selects
watchfiles 1.3.0 and lists compatible wheels.
Summary
This PR widens Python 3.14 install support, changes when task creation replies and where production client requests go, and updates release and CI workflows. It also documents main as the integration branch and adds security scanning workflows.
- Allows
watchfiles 1.x and refreshes the lockfile.
- Waits for task creation to finish before replying, while event sending stays asynchronous.
- Points production clients at the production service and updates release and CI automation.
Reviews (3) · Last reviewed commit: "fix(deps): allow watchfiles 1.x so agent..."
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
watchfiles 0.24.0 ships no CPython 3.14 wheel, so `uv tool install agentex-sdk`
on a 3.14 interpreter falls back to a maturin source build and fails, even
though the package advertises 3.14 in its classifiers. watchfiles 1.x
publishes abi3 wheels that cover 3.14 and keeps the `awatch` API used by
run_handlers.py.
Loosen the specifier to <2.0 and upgrade the locked release
(`uv lock --upgrade-package watchfiles`, 0.24.0 -> 1.3.0) so installs from
the lock get the wheel too. Verified: watchfiles 1.3.0 installs and imports
on CPython 3.14.7, and tests/lib/cli passes on 3.12.
Comments Outside Diff
These findings could not be posted inline.
-
Lock records old package versions uv.lock:18 ▶
uv.lock records both workspace packages as 0.21.0, but their pyproject.toml files declare 0.28.2. A developer checking whether the lock is current gets a stale-lock result, and a normal uv sync has to rewrite it. Please regenerate the lock after the version bump.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Want your agent to iterate on Greptile's feedback? Start a greploop in Cursor and it will work through the open comments and keep going until this PR reviews clean.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Reviewers
At least 1 approving review is required to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|