GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update SDK for v2 APIs by EvanWang2 · Pull Request #101 · scaleapi/scaleapi-python-client

Conversation

@EvanWang2

@EvanWang2 EvanWang2 commented Jul 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

  • Update SDK for v2 APIs
  • See https://docs.genai.scale.com/get-started/quickstart for list of v2 APIs
  • Am I supposed to write tests? (sounds a bit redundant if the endpoints already have them)

How did you test your code?

Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.

  • Created new unit tests in tests/ for the newly implemented methods
  • Updated existing unit tests in tests/ to cover changes made to existing methods

Checklist

Please make sure all items in this checklist have been fulfilled before sending your PR out for review!

  • I have commented my code in details, particularly in hard-to-understand areas
  • I have updated Readme.rst document with examples for newly implemented public methods
  • I have reviewed Deployment and Publishing Guide for Python SDK document
  • I incremented the SDK version in _version.py (unless this PR only updates the documentation).
  • In order to release a new version, a "Release Summary" needs to be prepared and published after the merge

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EvanWang2
EvanWang2 force-pushed the evan/CONN-421/update-sdk-for-v2-apis branch from 226279a to 20a7bc8 Compare July 14, 2025 03:41
@EvanWang2
Update SDK for v2 APIs
186f18e
@EvanWang2
EvanWang2 force-pushed the evan/CONN-421/update-sdk-for-v2-apis branch from 20a7bc8 to 186f18e Compare July 14, 2025 03:47
michaelbishoff
michaelbishoff reviewed Jul 14, 2025
View reviewed changes

@michaelbishoff michaelbishoff left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget why this file is commented out, but can we add some tests here that use only the v2 APIs. The tests ensure that the generated client is valid (we saw an edge case where oneOf properties in the openapi.yaml file didn't generate correctly)

https://github.com/scaleapi/scaleapi-python-client/blob/master/tests/test_v2_client.py

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
EvanWang2 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
michaelbishoff
michaelbishoff reviewed Jul 14, 2025
View reviewed changes

@michaelbishoff michaelbishoff left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the version
https://github.com/scaleapi/scaleapi-python-client/pull/99/files#diff-16c2b6ca2c519545d0787aa3b67ac9d24917b3bc19aeac8a9b94149ca5ccb443R1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
EvanWang2 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@EvanWang2
Update readme
a17b1bb
@EvanWang2
EvanWang2 force-pushed the evan/CONN-421/update-sdk-for-v2-apis branch from dc87fa2 to a17b1bb Compare July 17, 2025 23:06
EvanWang2 added 4 commits July 17, 2025 16:10
@EvanWang2
Fix pause/resume test timing issue
f6a2235
@EvanWang2
Fix pause/resume test to handle empty batch behavior
c1eaf04
@EvanWang2
Apply black formatting to test file
b06809e
@EvanWang2
Update Version
9e60f42
@EvanWang2

EvanWang2 commented Jul 18, 2025

Copy link
Copy Markdown
Contributor Author

Unable to create a chat project with template variables in the test SDK environment, so there are no tests for task creation and fetching. The test API key I use doesn't associate with the projects under my account.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
michaelbishoff
michaelbishoff approved these changes Jul 18, 2025
View reviewed changes
@EvanWang2
EvanWang2 merged commit 7829731 into master Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelbishoff michaelbishoff michaelbishoff approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EvanWang2 @michaelbishoff
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.