GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make project_name optional for get_tasks_count by fatihkurtoglu · Pull Request #94 · scaleapi/scaleapi-python-client

Conversation

@fatihkurtoglu

@fatihkurtoglu fatihkurtoglu commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

Pull Request Summary

Description

project_name will be optional for get_tasks_count method.
Providing either project or batch name will be enough to be consumed with the method.

How did you test your code?

Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.

  • Created new unit tests in tests/ for the newly implemented methods
  • Updated existing unit tests in tests/ to cover changes made to existing methods

Checklist

Please make sure all items in this checklist have been fulfilled before sending your PR out for review!

  • I have commented my code in details, particularly in hard-to-understand areas
  • I have updated Readme.rst document with examples for newly implemented public methods
  • I have reviewed Deployment and Publishing Guide for Python SDK document
  • I incremented the SDK version in _version.py (unless this PR only updates the documentation).
  • In order to release a new version, a "Release Summary" needs to be prepared and published after the merge

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@fatihkurtoglu
Make project optional for get_tasks_count
f2a33f8
@fatihkurtoglu
fatihkurtoglu requested review from jonathanfeng-scale and patrick-scale August 27, 2024 00:29
jonathanfeng-scale
jonathanfeng-scale approved these changes Aug 27, 2024
View reviewed changes
@fatihkurtoglu
fatihkurtoglu merged commit 54c3b3f into master Aug 27, 2024
@fatihkurtoglu
fatihkurtoglu deleted the fatih/update-task-count-method branch August 27, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrick-scale patrick-scale Awaiting requested review from patrick-scale
1 more reviewer
@jonathanfeng-scale jonathanfeng-scale jonathanfeng-scale approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@fatihkurtoglu @jonathanfeng-scale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.