GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Test ops.yaml files can be merged incorrectly · Issue #229 · scijava/scijava

Test ops.yaml files can be merged incorrectly #229

New issue
Copy link
New issue
Copy link
Closed as not planned
Closed as not planned
Test ops.yaml files can be merged incorrectly#229
Copy link
Labels
bug
Milestone
unscheduled

Description

@ctrueden
ctrueden
opened on May 30, 2024
Issue body actions

With 5da8173, I removed the progress reporting from the DefaultOpEnvironment's op discovery, because it was failing the OpRegressionTest on one of my systems. Investigation shone light onto three distinct issues, the first of which is #228, which I believe is a cascading failure triggered by the second and third issues, described here. First, snakeyaml rejects a mangled scijava-ops-image/target/test-classes/ops.yaml file:

Caused by: java.lang.ExceptionInInitializerError: Exception
org.yaml.snakeyaml.scanner.ScannerException: while scanning for the
next token; found character '@' that cannot start any token.
(Do not use @ for indentation);  in 'reader', line 26008, column 2:
  {@code <C>}
   ^ [in thread "main"]
    at [email protected]/org.yaml.snakeyaml.scanner.ScannerImpl.fetchMoreTokens(ScannerImpl.java:445)
    ...
    at [email protected]/org.yaml.snakeyaml.Yaml.load(Yaml.java:434)
    at org.scijava.ops.engine@0-SNAPSHOT/org.scijava.ops.engine.yaml.impl.YAMLOpInfoDiscoverer.parse(YAMLOpInfoDiscoverer.java:104)
    at org.scijava.ops.engine@0-SNAPSHOT/org.scijava.ops.engine.yaml.impl.YAMLOpInfoDiscoverer.lambda$discover$0(YAMLOpInfoDiscoverer.java:78)

The mangling takes the form of a rogue string {@code <C>} on its own line with no indentation, which appears to have overwritten some number of other lines of YAML, leading to improper indentation. (I tried diffing against a properly merged ops.yaml on an unaffected system, but the scijava-ops-indexer does not sort the op blocks, leading to ordering inconsistency, which makes diffing ineffective.)

I suspect the mangling is rooted in a third issue: there is a Ruby script present in the Maven build infrastructure that gets executed using script-maven-plugin, which might be the culprit. But further investigation is needed: it is suspicious that with the removal of progress reporting from DefaultOpEnvironment construction (5da8173, which works around #228), the YAML parsing issue seems to disappear—but it is hard to believe that these two things could actually be related...

Activity

  1. ctrueden
    added this to the unscheduled milestone on May 30, 2024
  2. ctrueden
    added
    bug
    on May 30, 2024
  3. ctrueden commented on Jul 10, 2024

    @ctrueden
    ctrueden
    on Jul 10, 2024
    MemberAuthor
    More actions

    I'm unable to reproduce the ops.yaml mangling anymore. My affected system still exhibits the problem described in #228, but I don't know the root cause. So for now—and especially in light of #243—let's close this.

  4. ctrueden
    closed this as not plannedon Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      • unscheduledNo due date

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.