GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ScriptService: add getScript(String,String) signature by imagejan · Pull Request #390 · scijava/scijava-common

Conversation

@imagejan

@imagejan imagejan commented Jun 19, 2020

Copy link
Copy Markdown
Member

This makes it easier to retrieve a ScriptInfo object from a script string (without going via File).

Closes #389.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@imagejan

imagejan commented Jun 19, 2020

Copy link
Copy Markdown
Member Author

I refactored ScriptServiceTest a bit to initialize the Context in a @Before method, and dispose it @After the tests.

@ctrueden what do you think about the re-use of the ScriptLanguage from ScriptInfoTest$BindingSizes? Should we instead make BindingSizes its own class within the tests? There are actually two nested ScriptLanguage implementations in the tests currently: ScriptInfoTest$BindingSizes and ScriptEngineTest$Rot13.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@imagejan
imagejan force-pushed the scriptinfo-from-string branch from 0b2e588 to ab9dad2 Compare September 3, 2020 18:36
@imagejan
imagejan force-pushed the scriptinfo-from-string branch from ab9dad2 to fc00c05 Compare December 18, 2020 19:10
@imagejan
ScriptService: add getScript(String,String) signature
0fc27eb 
This makes it easier to retrieve a ScriptInfo object from a script string (without going via File).

Closes #389.
@imagejan
imagejan force-pushed the scriptinfo-from-string branch from fc00c05 to 0fc27eb Compare January 19, 2021 19:52
@ctrueden
ctrueden force-pushed the master branch 3 times, most recently from 53b6733 to 3dc99c9 Compare November 7, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add convenience method to retrieve ScriptInfo/ModuleInfo from script

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@imagejan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.