GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Always ignore commented script parameters by imagejan · Pull Request #403 · scijava/scijava-common

Conversation

@imagejan

@imagejan imagejan commented Oct 25, 2020

Copy link
Copy Markdown
Member

Closes #398.

Before this commit, commented-out new-style (#@) script parameters were ignored when in the script body, but parsed when in the script header, because they matched the pattern for old-style parameter syntax.
We now explicitly omit lines with new-style syntax preceded by non-word characters from being matched, so the behavior is consistent, independent of the position of the parameter in the script.

Without this change in ParameterScriptProcessor, the test added in this commit would fail with:

[ERROR]   ParameterScriptProcessorTest.testScriptParameterParsing:49 expected null, but was:<commentedHeaderParameter: required=true, persisted=true>

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ctrueden reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@imagejan
Always ignore commented script parameters
b1bab69 
Before this commit, commented-out new-style (#@) script parameters were ignored when in the script body, but parsed when in the script header, because they matched the pattern for old-style parameter syntax.
We now explicitly omit lines with new-style syntax preceded by non-word characters from being matched, so the behavior is consistent independent of the position of the parameter in the script.

Without this change in ParameterScriptProcessor, the test added in this commit would fail with:

[ERROR]   ParameterScriptProcessorTest.testScriptParameterParsing:49 expected null, but was:<commentedHeaderParameter: required=true, persisted=true>
@ctrueden
ctrueden merged commit 10ac353 into master Oct 26, 2020
@ctrueden
ctrueden deleted the fix-commented-parameters branch October 26, 2020 19:43
@ctrueden

ctrueden commented Oct 26, 2020

Copy link
Copy Markdown
Member

Perfect! Thank you, @imagejan!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@imagejan imagejan mentioned this pull request Dec 4, 2020
IllegalStateException in logging framework when executing a script #410
Open
@imagesc-bot

imagesc-bot commented May 5, 2021

Copy link
Copy Markdown

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/handle-cross-dependencies-between-update-sites/52039/16
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent behavior with commented script parameters

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@imagejan @ctrueden @imagesc-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.