GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — LogService: Make getLevel() more robust against ClassNotFoundException by maarzt · Pull Request #411 · scijava/scijava-common

Conversation

@maarzt

@maarzt maarzt commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

This should fix issue: #410

Previously: If fine grained log levels are set LogService would call CallingClassUtils.getCallingClass() to find the appropriate log level for this class. This process would fail if the calling class could not be loaded with the default class loader. A IllegalStateException would be thrown instead.

This PR fixes this behavior. The class name is used rather the the class object. This avoids using Class.forName(...) if possible. But Class.forName(...) is still used to check for the presence of the IgnoreAsCallingClass annotation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@maarzt
LogService: Make getLevel() more robust against ClassNotFoundException
1e70db2
@maarzt maarzt mentioned this pull request Dec 3, 2020
IllegalStateException in logging framework when executing a script #410
Open
ctrueden
ctrueden requested changes Dec 8, 2020
View reviewed changes

@ctrueden ctrueden left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maarzt Thanks a bunch for working on this! Especially while on leave. Much appreciated.

I just have one request, to avoid using Class.forName in favor of SciJava's unified class loading access method.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/main/java/org/scijava/log/CallingClassUtils.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@maarzt
CallingClassUtils: replace Class.forName() with Context.getClassLoader()
b80f6fe 
Class.forName() will fail if the threads class loader is not set.
@ctrueden
ctrueden merged commit afe795a into master Dec 9, 2020
@ctrueden
ctrueden deleted the fix-logservice-calling-class branch December 9, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctrueden ctrueden ctrueden requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@maarzt @ctrueden
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.