GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix jvm_version parsing of non-numeric version suffixes by ncittm · Pull Request #92 · scijava/scyjava

Conversation

@ncittm

@ncittm ncittm commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

The old regex captured the entire quoted version string, including
non-numeric suffixes like "-internal" or "_312", which broke int()
conversion downstream. Now only the leading dot-separated digit
groups are captured.

Extract jvm_version parsing into a testable helper function.

Closes #91.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ncittm added 2 commits August 13, 2026 11:04
@ncittm
Extract jvm_version parsing into a testable helper function
7a193cc 
Split the version-string-to-tuple conversion out of jvm_version() into
_jvm_version_str_to_tuple() and add unit tests.
@ncittm
Fix jvm_version parsing of non-numeric version suffixes
70b8d35 
The old regex captured the entire quoted version string, including
non-numeric suffixes like "-internal" or "_312", which broke int()
conversion downstream. Now only the leading dot-separated digit
groups are captured.

These examples now work as expected:
* OpenJDK 11.0.9.1-internal -> (11, 0, 9, 1)
* OpenJDK 1.8.0_312 -> (1, 8, 0)
@ctrueden

ctrueden commented Aug 13, 2026

Copy link
Copy Markdown
Member

Awesome—thanks @ncittm! ✨
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ctrueden @claude
Make the code linter happy
9e20157 
Co-authored-by: Claude Sonnet 5 <[email protected]>
@ctrueden
ctrueden force-pushed the fix-jvm-version branch from 4b69fd7 to 9e20157 Compare August 13, 2026 16:44
@ctrueden
ctrueden merged commit 50092cb into scijava:main Aug 13, 2026
7 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scyjava does not recognise Java version of openjdk=17.0.18 from conda-forge

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ncittm @ctrueden
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.