GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Doc copy glossary term by usmanwajid09 · Pull Request #35379 · scikit-learn/scikit-learn

Conversation

@usmanwajid09

@usmanwajid09 usmanwajid09 commented Nov 11, 2026

Copy link
Copy Markdown

Reference Issues/PRs

Closes #28793
Supersedes #30307

What does this implement/fix? Explain your changes.

  • Added a combined copy / copy_x / copy_X entry to the glossary
    (doc/glossary.rst), under Parameters.
  • Linked the term inline from the docstrings that use those parameters
    (22 files), using :term:copy / :term:copy_x / :term:copy_X,
    following StefanieSenger's feedback on DOC Document copy parameter and add link to the glossary entry #30307.
  • Wording follows lesteve's guidance on Unexpected behavior of sklearn.feature_selection.mutual_info_regression if copy=False #28793: copy=False tries to
    avoid copying to save memory, but it does not guarantee in-place
    modification, so callers should not rely on the input either remaining
    intact or being modified in a specific way.
  • Dropped Birch from the original PR: its copy parameter no longer
    exists on main. Also changed "will be overwritten" to "may be
    overwritten" in _mutual_info.py, since y is copied there.
  • Documentation only, no behaviour change, so no changelog entry.

Introduce yourself

  • I'm Usman Wajid 7th-semester CS student at FAST-NUCES, Lahore.
  • First contribution to scikit-learn; I use it in my ML projects
    (house-price, churn, sentiment) and am preparing for GSoC 2027.

AI usage disclosure

I used AI assistance for:

  • Research and understanding

Any other comments?

  • The original work was @lamdang2k's in DOC Document copy parameter and add link to the glossary entry #30307. This PR rebases it onto
    current main and applies the review feedback from that PR.
  • Checks run: ruff check and ruff format clean on all 22 modified files;
    test_docstring_parameters_consistency (4 passed),
    test_docstring_parameters (210 passed), test_docstrings filtered to the
    modified classes/functions (461 passed). Pyrefly was run directly with
    0 errors, because the pre-commit pyrefly hook could not download from
    PyPI on my machine (transient SSL/DNS error).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
usmanwajid09 added 3 commits November 11, 2026 10:12
@usmanwajid09
DOC Document copy, copy_x, copy_X in glossary and link inline
9d195fe
@usmanwajid09
DOC Document copy, copy_x, copy_X in glossary and link inline
4c30d8c
@usmanwajid09
DOC Remove accidentally committed stray file
97ef1f0
@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thank you for opening your first pull request to scikit-learn! 🎉

To help get your contribution reviewed, please make sure that:

  • You have filled out the pull request template.

  • The pull request addresses an existing issue that is ready for contribution (e.g. not tagged as 'Needs Triage', 'Needs Decision', ...). If you are proposing a new feature, please open an issue to discuss it first.

  • There are no other open pull requests already targeting the same issue.

  • You have followed the pull request checklist. In particular, linting and tests should pass.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the size/L label Nov 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected behavior of sklearn.feature_selection.mutual_info_regression if copy=False

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@usmanwajid09
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.