GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — introduce PMD check · scribejava/scribejava@7301f7a

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

changelog
pmd.xml
pom.xml
scribejava-core/src/test/java/com/github/scribejava/core/oauth
- OAuth20ServiceTest.java

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎changelog‎`

Copy file name to clipboardExpand all lines: changelog

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,6 @@`
	`1`	`+[SNAPSHOT]`
	`2`	`+ * add PMD checks on compile`
	`3`	`+`
`1`	`4`	`[6.5.1]`
`2`	`5`	`* cleanup deprecates methods`
`3`	`6`

Collapse file

`‎pmd.xml‎`

Copy file name to clipboard

+11Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,11 @@`
	`1`	`+<?xml version="1.0"?>`
	`2`	`+<ruleset name="ScribeJava PMD ruleset"`
	`3`	`+ xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"`
	`4`	`+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"`
	`5`	`+ xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">`
	`6`	`+`
	`7`	`+ <description>`
	`8`	`+ This ruleset defines the PMD rules for project "ScribeJava".`
	`9`	`+ </description>`
	`10`	`+`
	`11`	`+</ruleset>`

Collapse file

`‎pom.xml‎`

Copy file name to clipboardExpand all lines: pom.xml

+50-1Lines changed: 50 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@`
`147`	`147`	`<version>3.8.0</version>`
`148`	`148`	`<configuration>`
`149`	`149`	`<encoding>UTF-8</encoding>`
`150`		`- <release>7</release>`
	`150`	`+ <release>${java.release}</release>`
`151`	`151`	`<showDeprecation>true</showDeprecation>`
`152`	`152`	`</configuration>`
`153`	`153`	`</plugin>`
`@@ -225,9 +225,58 @@`
`225`	`225`	`</execution>`
`226`	`226`	`</executions>`
`227`	`227`	`</plugin>`
	`228`	`+ <plugin>`
	`229`	`+ <groupId>org.apache.maven.plugins</groupId>`
	`230`	`+ <artifactId>maven-pmd-plugin</artifactId>`
	`231`	`+ <version>3.11.0</version>`
	`232`	`+ <dependencies>`
	`233`	`+ <dependency>`
	`234`	`+ <groupId>net.sourceforge.pmd</groupId>`
	`235`	`+ <artifactId>pmd-core</artifactId>`
	`236`	`+ <version>${pmdVersion}</version>`
	`237`	`+ </dependency>`
	`238`	`+ <dependency>`
	`239`	`+ <groupId>net.sourceforge.pmd</groupId>`
	`240`	`+ <artifactId>pmd-java</artifactId>`
	`241`	`+ <version>${pmdVersion}</version>`
	`242`	`+ </dependency>`
	`243`	`+ <dependency>`
	`244`	`+ <groupId>net.sourceforge.pmd</groupId>`
	`245`	`+ <artifactId>pmd-javascript</artifactId>`
	`246`	`+ <version>${pmdVersion}</version>`
	`247`	`+ </dependency>`
	`248`	`+ <dependency>`
	`249`	`+ <groupId>net.sourceforge.pmd</groupId>`
	`250`	`+ <artifactId>pmd-jsp</artifactId>`
	`251`	`+ <version>${pmdVersion}</version>`
	`252`	`+ </dependency>`
	`253`	`+ </dependencies>`
	`254`	`+ <configuration>`
	`255`	`+ <targetJdk>1.${java.release}</targetJdk>`
	`256`	`+ <linkXRef>false</linkXRef>`
	`257`	`+ <rulesets>`
	`258`	`+ <ruleset>../pmd.xml</ruleset>`
	`259`	`+ </rulesets>`
	`260`	`+ <verbose>true</verbose>`
	`261`	`+ <analysisCache>true</analysisCache>`
	`262`	`+ <includeTests>true</includeTests>`
	`263`	`+ </configuration>`
	`264`	`+ <executions>`
	`265`	`+ <execution>`
	`266`	`+ <goals>`
	`267`	`+ <goal>check</goal>`
	`268`	`+ </goals>`
	`269`	`+ </execution>`
	`270`	`+ </executions>`
	`271`	`+ </plugin>`
`228`	`272`	`</plugins>`
`229`	`273`	`</build>`
`230`	`274`
	`275`	`+ <properties>`
	`276`	`+ <java.release>7</java.release>`
	`277`	`+ <pmdVersion>6.12.0</pmdVersion>`
	`278`	`+ </properties>`
	`279`	`+`
`231`	`280`	`<profiles>`
`232`	`281`	`<profile>`
`233`	`282`	`<id>release-sign-artifacts</id>`

Collapse file

`‎scribejava-core/src/test/java/com/github/scribejava/core/oauth/OAuth20ServiceTest.java‎`

Copy file name to clipboardExpand all lines: scribejava-core/src/test/java/com/github/scribejava/core/oauth/OAuth20ServiceTest.java

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public void shouldProduceCorrectRequestSync() throws IOException, InterruptedExc`
`39`	`39`	`final String authorize = base64Encoder.encodeToString(`
`40`	`40`	`String.format("%s:%s", service.getApiKey(), service.getApiSecret()).getBytes(Charset.forName("UTF-8")));`
`41`	`41`
`42`		`- assertEquals(OAuthConstants.BASIC + " " + authorize, map.get(OAuthConstants.HEADER));`
	`42`	`+ assertEquals(OAuthConstants.BASIC + ' ' + authorize, map.get(OAuthConstants.HEADER));`
`43`	`43`
`44`	`44`	`assertEquals("user1", map.get("query-username"));`
`45`	`45`	`assertEquals("password1", map.get("query-password"));`
`@@ -65,7 +65,7 @@ public void shouldProduceCorrectRequestAsync() throws ExecutionException, Interr`
`65`	`65`	`final String authorize = base64Encoder.encodeToString(`
`66`	`66`	`String.format("%s:%s", service.getApiKey(), service.getApiSecret()).getBytes(Charset.forName("UTF-8")));`
`67`	`67`
`68`		`- assertEquals(OAuthConstants.BASIC + " " + authorize, map.get(OAuthConstants.HEADER));`
	`68`	`+ assertEquals(OAuthConstants.BASIC + ' ' + authorize, map.get(OAuthConstants.HEADER));`
`69`	`69`
`70`	`70`	`assertEquals("user1", map.get("query-username"));`
`71`	`71`	`assertEquals("password1", map.get("query-password"));`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.