Description

NathalieGprog

opened on Apr 18, 2025

Issue body actions

scribejava/scribejava-core/src/main/java/com/github/scribejava/core/oauth/AccessTokenRequestParams.java

Line 45 in 8970e8e

extraParameters = new HashMap<>();

The method throw NullPointerException each time that it call when the class variable extraParameters is null because the initialisation is done for the parameter variable and not for the class variable with the same name. The this. is missing.

    public AccessTokenRequestParams addExtraParameters(Map<String, String> extraParameters) {
        if (extraParameters == null || extraParameters.isEmpty()) {
            return this;
        }
        if (this.extraParameters == null) {
            extraParameters = new HashMap<>(); // Error
        }
        this.extraParameters.putAll(extraParameters);
        return this;
    }

It should be :

        if (this.extraParameters == null) {
            this.extraParameters = new HashMap<>();
        }

Activity

1. king-407 commented on Jun 16, 2026

   

   king-407

   on Jun 16, 2026

   More actions

   Hi, I would like to work on this issue.

   From what I understand, AccessTokenRequestParams#addExtraParameters initializes the method parameter instead of the this.extraParameters field when the field is null. Because of that, the following this.extraParameters.putAll(...) call can throw a NullPointerException.

   I can add a focused regression test for this case and then fix the initialization to assign this.extraParameters = new HashMap<>().

   Would a contribution in this direction be welcome?

Issue actions