GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [readme] Change variable naming in example by tipsy · Pull Request #1040 · scribejava/scribejava

Conversation

@tipsy

@tipsy tipsy commented Jun 4, 2022

Copy link
Copy Markdown
Contributor

This is a more common convention, which is also used in your own examples: https://github.com/scribejava/scribejava/blob/master/scribejava-apis/src/test/java/com/github/scribejava/apis/examples/Google20Example.java#L27-L35

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tipsy
[readme] Change variable naming in example
4d7a88e 
This is a more common convention, which is also used in your own examples: https://github.com/scribejava/scribejava/blob/master/scribejava-apis/src/test/java/com/github/scribejava/apis/examples/Google20Example.java#L27-L35
@tipsy

tipsy commented Jun 21, 2023

Copy link
Copy Markdown
Contributor Author

Well, I guess this is not going to happen.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tipsy tipsy closed this Jun 21, 2023
@kullfar kullfar reopened this Jun 22, 2023
@kullfar
kullfar merged commit b62f73a into scribejava:master Jun 22, 2023
@kullfar

kullfar commented Jun 22, 2023

Copy link
Copy Markdown
Member

Yeah.. Why not? You're absolutely right. client_id and client_secret naming are correct namings according to RFC https://datatracker.ietf.org/doc/html/rfc6749#appendix-A.1

So, let it be so in readme.md as well

ps. Sorry for a long delay ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tipsy

tipsy commented Jun 22, 2023

Copy link
Copy Markdown
Contributor Author

Thank you very much 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tipsy @kullfar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.