GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes #1172 and #1173 by glennblock · Pull Request #1177 · scriptcs/scriptcs

Conversation

@glennblock

@glennblock glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor
  • Locks Travis mono build version to 4.2.3.
  • Fixes cp command.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@glennblock
Fixes scriptcs#1172 and scriptcs#1173
5a16d28
@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

OK so pinning to Mono 4.2.3 seems to have worked. The 2 tests failing are because of the cp command.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

doh, my case sensitivity was wrong.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock
Fix case
1271b55
@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

Yay!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock

glennblock commented Sep 6, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@adamralph @ilovezfs pinning indeed fixed it for now.

adamralph reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock
glennblock merged commit b8b689d into scriptcs:dev Sep 6, 2016
@glennblock
glennblock deleted the travisfix branch September 6, 2016 07:59
@ilovezfs

ilovezfs commented Sep 6, 2016

Copy link
Copy Markdown

@glennblock nice work :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

@ilovezfs it won't fix it for brew though as you said because of the mono version.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock

glennblock commented Sep 6, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@ilovezfs based on where all the acceptance tests are failing in the code, it really looks like it is a very specific issue related to how mono is returning the stdout stream. The likelihood is that scriptcs itself will work fine. Do you want me to create for you the brew build.sh file?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ilovezfs

ilovezfs commented Sep 6, 2016

Copy link
Copy Markdown

@glennblock that would be great.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

@ilovezfs just committed build_brew.sh to dev, and master. It doesn't affect our release, so there was no problem just committing to master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

Yippee!

screen shot 2016-09-06 at 1 32 33 am

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ilovezfs

ilovezfs commented Sep 6, 2016

Copy link
Copy Markdown

@glennblock awesome 💚

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for the help!
On Tue, Sep 6, 2016 at 2:14 AM ilovezfs [email protected] wrote:

@glennblock https://github.com/glennblock awesome 💚

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1177 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAInRJGY4sQVMDYbEddyWFpzkbsEfIfEks5qnS7agaJpZM4J1i36
.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@glennblock @ilovezfs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.