GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Integration Tests for ZAP by J12934 · Pull Request #97 · secureCodeBox/secureCodeBox-v2

This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Conversation

@J12934

@J12934 J12934 commented Sep 23, 2020

Copy link
Copy Markdown
Member

This PR adds integration tests for the ZAP integration.

While adding these i've made some other improvements to improve the stability and debuggability of the tests:

  • Made ttlSecondsAfterFinished property on scanJobs configurable. Kind seems to already have the ttlAfterFinished controller running even thought its still an alpha feature. When this is enable its harder to log print logs of failing scanner containers as they might already be deleted.
  • Test helper will now print out logs of the scan container when it failed. This allows to easier debug why a test is failing.
  • Reduce test flakyness by giving the k8s api server more time (2 seconds) before fetching the final state of the finished scan. This reduces the likeliness that the tests fetch inconsistent scan state.
  • Swtich out all ZAP images to weekly releases (also the baseline scanType), as the 2.9.0 doesn't run on containerd cluster.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
J12934 added 12 commits September 21, 2020 12:37
@J12934
Add basic ZAP integration test
8cc7b21
@J12934
Properly set name on zap scan step
0221577
@J12934
Better debugging of failed scans during ci
2128e54
@J12934
Try to reduce flaky tests
30b1cac
@J12934
Duration is in sec not ms 🤦‍♂️
ead9eb7
@J12934
Get scan before deleting it
77d0244
@J12934
More debugging
641a4fa
@J12934
Fix namespace
af3da2a
@J12934
Only apply ttlSecondsAfterFinished when set in values
f458f5f
@J12934
Print out error
971eee5
@J12934
Echo out logging exception error
d4260d8
@J12934
Also switch zap baseline image to wekly
0b228ce
Required to run zap on non docker (e.g. containerd clusters)
Also updated the used zap image
@J12934 J12934 added the testing label Sep 23, 2020
@J12934
Merge branch 'master' into zap-integration-tests
4e5b665
nigthknight
nigthknight approved these changes Sep 24, 2020
View reviewed changes
@nigthknight
nigthknight merged commit feb5b8a into master Sep 24, 2020
@J12934
J12934 deleted the zap-integration-tests branch September 29, 2020 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@nigthknight nigthknight nigthknight approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@J12934 @nigthknight
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.