GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: preserve HTTP error subclasses when pickling by Shubham-Padkonde · Pull Request #163 · sendgrid/python-http-client

Conversation

@Shubham-Padkonde

@Shubham-Padkonde Shubham-Padkonde commented Oct 4, 2026

Copy link
Copy Markdown

HTTPError.__reduce__ always reconstructs the base HTTPError class. Consequently, pickling a TooManyRequestsError or ServiceUnavailableError succeeds but loses its type. Callers receiving an exception from a worker can no longer catch the original subclass to apply their retry policy.

Reconstruct type(self) with the existing four serialized fields. This follows up on #148 and retains its pickle support while preserving the exception class.

The regression covers every built-in status-specific error and the generic fallback, using every pickle protocol available in Python 3.12. All 66 subclass/protocol combinations fail before the fix and pass afterward; all 12 client unit tests pass. Pycodestyle and Pyflakes pass on both changed files.

Full discovery runs 14 tests: 13 pass and the existing copyright-year test fails because LICENSE says 2023 while the current year is 2026. No license text was changed. The legacy Python versions in CI were not run locally.

Checklist

  • Contributions are made under the project's license.
  • This is a functional change with regression coverage.
  • Read the contribution guidelines; this targets main, the current CI/default branch (development no longer exists).
  • The PR uses a conventional title.
  • Tests demonstrate the fix.
  • No new public API or documentation changes are required.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Shubham-Padkonde
fix: preserve HTTP error subclasses when pickling
b6339f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Shubham-Padkonde
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.