GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: fix four links to test files that moved in 2021 by melbinjp · Pull Request #1133 · sendgrid/sendgrid-python

Conversation

@melbinjp

@melbinjp melbinjp commented Aug 21, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Four links in the docs point at test files that moved in 1dcc378 (2021-12-14, "test: split up unit and integ tests"). Nothing else is touched.

file link now
CONTRIBUTING.md:76 test/test_sendgrid.py test/unit/test_sendgrid.py
TROUBLESHOOTING.md:127 test/test_eventwebhook.py test/unit/test_eventwebhook.py
sendgrid/helpers/inbound/README.md:130 test/test_config.py test/unit/test_config.py
sendgrid/helpers/inbound/README.md:131 test/test_parse.py test/unit/test_parse.py

Three of those are plain renames. The CONTRIBUTING.md one is not, so here is the reasoning in full.

1dcc378 moved the original file to test/integ/test_sendgrid.py (R100, content unchanged), and it is the only test_sendgrid.py that commit touched. A second one appeared later at test/unit/test_sendgrid.py, added by b5afcca (2023-11-24) with the GDPR region work, and it holds unit tests of the client host. The CONTRIBUTING sentence asks the reader to add unit tests, so it points there rather than at the file git paired the rename with. Say the word if you would rather it named both.

CONTRIBUTING.md is the file a first-time contributor is told to read, and its link to the test they are asked to edit has been a 404 for a little under five years.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
melbinjp added 4 commits August 21, 2026 18:22
@melbinjp
docs: point CONTRIBUTING.md at the test paths that exist
b70b2b6
@melbinjp
docs: point TROUBLESHOOTING.md at the test paths that exist
37dcdb3
@melbinjp
docs: point sendgrid/helpers/inbound/README.md at the test paths that…
dba7ab1
… exist
@melbinjp
docs: the sentence asks for unit tests, so point it at the unit file
715fb3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@melbinjp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.