GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add option for copying dependencies instead of creating a link by Psycholive · Pull Request #685 · serverless/serverless-python-requirements

This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@Psycholive

@Psycholive Psycholive commented Mar 7, 2022

Copy link
Copy Markdown

I have a case where a windows folder containing sources is mounted in a linux VM and therefore symlinks cannot be created in .serverless folder.

This PR add a new option to copy dependencies in .serverless folder instead of creating a symlink. It is less beautiful and quick but it is the only option I see in my case.

It is possible to include this option in next release?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pgrzesik
pgrzesik suggested changes Mar 8, 2022
View reviewed changes

@pgrzesik pgrzesik left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Psycholive - I have some comments, it also would be good to cover that functionality with a test case

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread README.md Outdated
```yaml
custom:
pythonRequirements:
useFinalCopy: true

@pgrzesik pgrzesik Mar 8, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this property name is a great choice here - it doesn't really convey the meaning in my opinion - maybe we could use something more descriptive? Like useSymlinks: false or something along those lines? What do you think?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Psycholive Psycholive Mar 8, 2022

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property naming is always a difficult task :) Why not useSymlinks indeed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread README.md Outdated

Before final packaging, a link is created in .serverless folder for python dependencies.
If it is not possible to create a symbolic link, dependencies can be copied instead of linked
whith the foloowing option:

@pgrzesik pgrzesik Mar 8, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple typos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Psycholive Psycholive Mar 8, 2022

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Didier SENMARTIN added 3 commits March 8, 2022 14:49
Didier SENMARTIN @Psycholive
add useFinalCopy option
94d71a1
Didier SENMARTIN @Psycholive
Code review
12f7ae3
Didier SENMARTIN @Psycholive
Prettier
ac85044
@Psycholive
Psycholive force-pushed the master branch from 1421be4 to ac85044 Compare March 8, 2022 13:49
@pgrzesik

pgrzesik commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Hey @Psycholive - sorry for not responding for a long time. Do you still have time to finalize this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pgrzesik pgrzesik pgrzesik requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Psycholive @pgrzesik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.