GeezerVison

PR Summary

Medium Risk
Touches polling execution and webhook dispatch by replacing HTTP self-calls with in-process processing and shared orchestration, so regressions could impact webhook triggering, state updates, or concurrency/locking behavior across providers.

Overview
Refactors polling to a provider handler + orchestrator model (lib/webhooks/polling/*), replacing per-provider polling services with gmail/imap/outlook/rss handlers registered via registry.ts and executed through pollProvider() with shared concurrency and DB utilities.

Consolidates API endpoints by replacing separate /api/webhooks/poll/{provider} routes with a single dynamic app/api/webhooks/poll/[provider]/route.ts, including provider validation and per-provider Redis lock keys.

Eliminates the polling self-POST pattern by adding processPolledWebhookEvent() in lib/webhooks/processor.ts, so polling handlers dispatch webhook executions directly (with admission control, deployment block checks, and queueing) instead of calling /api/webhooks/trigger/... over HTTP.

^{Reviewed by Cursor Bugbot for commit 4a1000c. Configure here.}

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 8, 2026 3:48am

Greptile Summary

This PR is a well-scoped structural refactor that consolidates four near-identical polling services (Gmail, Outlook, IMAP, RSS) into a unified handler pattern under lib/webhooks/polling/, and replaces four duplicate route files with a single dynamic [provider] route. The primary behavioral improvement is the elimination of the self-POST anti-pattern via the new processPolledWebhookEvent() function in processor.ts, which routes polled events directly in-process.

Key changes:

• New lib/webhooks/polling/ module: types.ts (strategy interface), registry.ts (handler lookup + VALID_POLLING_PROVIDERS), utils.ts (6 shared helpers extracted from per-provider duplication), orchestrator.ts (entry point), and one handler file per provider.
• processor.ts: Adds processPolledWebhookEvent() that admits, preprocesses, checks block existence, handles billing, and dispatches to BullMQ or inline job queue — bypassing the HTTP round-trip.
• app/api/webhooks/poll/[provider]/route.ts: Single dynamic route replacing 4 identical files; auth check correctly precedes provider validation; lock TTL tied to maxDuration.
• Deleted files: gmail-polling-service.ts, rss-polling-service.ts, and the 3 individual route files.
• All prior review feedback (archived webhook filtering, auth-before-enumeration ordering, idempotency import path) has been addressed in this version.

Confidence Score: 5/5

Safe to merge — all prior P1 concerns are resolved, no new correctness or security issues introduced.

All previously raised P1 findings (archived webhook filtering, auth-before-enumeration, idempotency import path) are addressed. Remaining findings are P2: a discarded preprocessing error detail, duplicated local interfaces in processor.ts, and verbose logger type annotations in private helpers. None affect runtime correctness.

apps/sim/lib/webhooks/processor.ts — minor observability gap in preprocessResult error handling and interface duplication.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    CRON["Helm Cron\n/api/webhooks/poll/{provider}"]
    ROUTE["[provider]/route.ts\nverifyCronAuth → VALID_POLLING_PROVIDERS\nacquireLock"]
    ORCHESTRATOR["orchestrator.ts\npollProvider()"]
    REGISTRY["registry.ts\ngetPollingHandler()"]
    UTILS_FETCH["utils.ts\nfetchActiveWebhooks()"]
    CONCURRENCY["utils.ts\nrunWithConcurrency(CONCURRENCY=10)"]
    GMAIL["gmail.ts\ngmailPollingHandler"]
    OUTLOOK["outlook.ts\noutlookPollingHandler"]
    IMAP["imap.ts\nimapPollingHandler"]
    RSS["rss.ts\nrssPollingHandler"]
    IDEMPOTENCY["pollingIdempotency\n(per item)"]
    PROCESSOR["processor.ts\nprocessPolledWebhookEvent()"]
    ADMIT["tryAdmit() ticket"]
    PREPROCESS["checkWebhookPreprocessing()"]
    DISPATCH["BullMQ / inline job queue\nwebhook-execution"]
    CRON --> ROUTE
    ROUTE --> ORCHESTRATOR
    ORCHESTRATOR --> REGISTRY
    ORCHESTRATOR --> UTILS_FETCH
    UTILS_FETCH --> CONCURRENCY
    CONCURRENCY --> GMAIL & OUTLOOK & IMAP & RSS
    GMAIL & OUTLOOK & IMAP & RSS --> IDEMPOTENCY
    IDEMPOTENCY --> PROCESSOR
    PROCESSOR --> ADMIT
    ADMIT --> PREPROCESS
    PREPROCESS --> DISPATCH

_{Reviews (2): Last reviewed commit: "fix(polling): use literal for maxDuratio..." | Re-trigger Greptile}

@greptile

@cursor review