GeezerVison

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 8, 2026 7:12am

PR Summary

Medium Risk
Broad but mechanical change across many API routes that alters client-visible HTTP status codes and error payloads for invalid requests; functional logic is otherwise unchanged.

Overview
Improves request validation handling across multiple tool API routes (Athena, CloudFormation, CloudWatch, DynamoDB, and third-party integrations) by explicitly catching z.ZodError and returning HTTP 400 with a validation message instead of bubbling into generic 500 responses.

Adds a defensive try/catch around navigator.clipboard.writeText() in CopyCodeButton so clipboard permission/focus failures don’t throw and break the UI flow.

^{Reviewed by Cursor Bugbot for commit 088cf23. Configure here.}

@greptile

@cursor review

@greptile

@cursor review

Greptile Summary

This PR addresses three stated review comments: (1) wrapping navigator.clipboard.writeText() in a try/catch in CopyCodeButton, (2) adding missing folder and past_chat cases in resolveResourceFromContext, and (3) returning HTTP 400 (not 500) for Zod validation errors across 8 Athena and multiple other API routes. The clipboard and HTTP 400 fixes are implemented correctly. However, the resolveResourceFromContext fix — which the PR description explicitly claims — is not present in any of the 36 changed files; apps/sim/app/workspace/[workspaceId]/home/home.tsx is missing from the changeset and the function still falls through to default: return null for folder and past_chat context kinds.

Key changes:

• CopyCodeButton: graceful try/catch around clipboard API
• 8 Athena routes, 7 CloudFormation routes, 7 CloudWatch routes, 6 DynamoDB routes, plus Google Drive/OneDrive/Outlook/Slack routes: ZodError now returns 400 instead of 500
• Slack, Outlook, Google Drive, and OneDrive ZodError responses also include success: false; Athena/CloudFormation/CloudWatch/DynamoDB do not — inconsistency remains between these two groups

Notable issue: The home.tsx resolveResourceFromContext function still has no folder or past_chat case, so dragged folders and tasks from the sidebar still silently return null and are never added to the resource panel.

Confidence Score: 4/5

Safe to merge for the API 400-fix and clipboard changes, but the claimed resolveResourceFromContext fix was never applied — the stated bug still exists in production.

One P1 gap: the PR description explicitly claims to add folder and past_chat cases to resolveResourceFromContext, but home.tsx is absent from the changeset and the function still returns null for both kinds. Dragging folders and tasks from the sidebar into chat continues to silently fail. The remaining two findings (missing success: false on Athena/DynamoDB/CloudFormation/CloudWatch ZodErrors, and any in the Outlook route) are P2. Score is 4 rather than 5 due to the unfixed P1 from the PR's stated scope.

apps/sim/app/workspace/[workspaceId]/home/home.tsx — the resolveResourceFromContext fix is entirely missing from this PR

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User drags item from sidebar] --> B{context.kind}
    B -->|workflow / current_workflow| C[return type: workflow]
    B -->|knowledge| D[return type: knowledgebase]
    B -->|table| E[return type: table]
    B -->|file| F[return type: file]
    B -->|folder missing| G[default: return null]
    B -->|past_chat missing| G
    G --> H[handleContextAdd receives null]
    H --> I[Resource silently NOT added to panel]
    C --> J[addResource called]
    D --> J
    E --> J
    F --> J
    J --> K[Resource appears in panel]

_{Reviews (1): Last reviewed commit: "fix(api): add success:false to ZodError ..." | Re-trigger Greptile}