GeezerVison is showing github.com — fix(settings): chip-consistency + shared credential-style resource row by waleedlatif1 · Pull Request #5308 · simstudioai/sim
Conversation
Summary
- chip: moved the default/filled hover into
active-keyed compound variants so each (variant, active) emits exactly one hover-hover:bg-*. Raw chipVariants({...}) consumers now render identically to cn(chipVariants({...})) ones — fixing the sidebar vs settings-sidebar active-hover divergence (selected rows darken on hover consistently). Verified byte-equivalent under tailwind-merge, so cn-wrapped consumers are unchanged.
- integrations: "Explore in chat" now uses
active (was a transparent/floating chip) so it's a filled active chip that darkens on hover.
- data-retention: folded the "Workspaces without an override inherit the organization defaults" helper out from under the Retention policies section into the page-level description (
navigation.ts), dropping the redundant wrapper.
- settings: extracted a shared
SettingsResourceRow (canonical rounded icon tile + title/desc + trailing slot; force-normalizes icons to 20px) and migrated recently-deleted, byok-key-manager, and credential-sets (×3) onto it — eliminating copy-pasted credential-row chrome drift. recently-deleted's Restore/View actions are now Chips (no more non-chip Buttons) and its icon uses the credential-style tile.
Type of Change
Testing
Tested manually. tsc clean (0 errors), biome clean across all touched files. No test asserts on chip class strings.
Checklist
- Code follows project style guidelines
- Self-reviewed my changes
- Tests added/updated and passing
- No new warnings introduced
- I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
- chip: move default/filled hover into active-keyed compound variants so raw chipVariants({...}) renders identically to cn(chipVariants({...})); fixes sidebar/settings-sidebar active-hover divergence (no change to cn-wrapped consumers)
- integrations: 'Explore in chat' uses active chip (darkens on hover) instead of floating text
- data-retention: fold the retention-policies helper into the page description; drop the redundant wrapper
- settings: extract shared SettingsResourceRow (rounded icon tile + title/desc + trailing, icons normalized to 20px); migrate recently-deleted, byok, and credential-sets onto it; recently-deleted actions are now Chips
vercel
Bot
commented
Jul 1, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cursor
Bot
commented
Jul 1, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
Low Risk
Presentation-only changes in shared Chip styling and settings UI; no API, auth, or retention logic changes.
Overview
Unifies settings list UI and fixes Chip hover behavior for active / default variants.
Chip (packages/emcn) — Default and filled hover styles move into active-keyed compound variants so each chip gets a single hover-hover:bg-*. Raw chipVariants({...}) callers match cn(chipVariants(...)), fixing inconsistent selected-row hover (e.g. sidebar vs settings). Integrations Explore in chat uses active for a filled, hover-darkening CTA.
Settings — New SettingsResourceRow (icon tile, title, description, trailing slot; icons normalized to 20px). BYOK, credential sets (invitations, memberships, manage), and recently deleted use it instead of duplicated row markup. Recently deleted swaps Button restore/view actions for Chip and bumps list icon sizing to match the tile.
Data retention — The “workspaces without an override inherit org defaults” note moves from the Retention policies section into the Data retention nav subtitle in navigation.ts; the in-section helper text and extra wrapper are removed (list layout unchanged).
Reviewed by Cursor Bugbot for commit 8f9aeed. Configure here.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Greptile Summary
This PR standardizes several settings rows and chip hover states. The main changes are:
- Moves default and filled chip hover classes into active-aware variants.
- Marks the integrations Explore chip as active.
- Adds a shared
SettingsResourceRow for BYOK, credential sets, and recently deleted items.
- Moves the data-retention inheritance note into the settings navigation copy.
Confidence Score: 5/5
This looks safe to merge.
- No blocking issues found in the changed code.
- The shared row keeps truncation and trailing actions separated.
- The chip variant change keeps non-active default and filled hover states covered.
Important Files Changed
| Filename |
Overview |
| packages/emcn/src/components/chip/chip.tsx |
Moves default and filled hover styling into active-keyed compound variants while keeping the default chip state covered. |
| apps/sim/app/workspace/[workspaceId]/settings/components/settings-resource-row/settings-resource-row.tsx |
Adds a shared resource row with a normalized icon tile, truncating title and description, and an optional trailing slot. |
| apps/sim/app/workspace/[workspaceId]/settings/components/byok/byok-key-manager.tsx |
Migrates BYOK provider rows to the shared settings resource row without changing the action rendering path. |
| apps/sim/app/workspace/[workspaceId]/settings/components/credential-sets/credential-sets.tsx |
Migrates invitation, membership, and managed credential-set rows to the shared settings resource row. |
| apps/sim/app/workspace/[workspaceId]/settings/components/recently-deleted/recently-deleted.tsx |
Migrates deleted-resource rows to the shared resource row and changes restore/view actions from buttons to chips. |
| apps/sim/ee/data-retention/components/data-retention-settings.tsx |
Removes the inline inheritance helper text after moving that message to the page-level description. |
| apps/sim/app/workspace/[workspaceId]/settings/navigation.ts |
Adds the data-retention inheritance note to the navigation description. |
| apps/sim/app/workspace/[workspaceId]/integrations/components/showcase-with-explore/showcase-with-explore.tsx |
Sets the Explore chip to the active visual state. |
| apps/sim/app/workspace/[workspaceId]/settings/components/settings-resource-row/index.ts |
Adds the barrel export for the new settings resource row component. |
Reviews (1): Last reviewed commit: "fix(settings): chip-consistency + shared..." | Re-trigger Greptile
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This branch was successfully deployed
1 active
deployment
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|