GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(emcn): stop calendar content bleeding through the modal backdrop by waleedlatif1 · Pull Request #5311 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The shared modal's backdrop-blur overlay did not reliably paint above page content the browser had GPU-promoted — position: sticky headers and z-indexed absolutes inside a scroll container (e.g. the scheduled-tasks calendar's sticky day headers, toolbar chevrons, and event chips). Those composited layers sorted above the overlay despite its higher z-index, bleeding through the backdrop and over the modal panel.
  • Fix: promote both the overlay and the content wrapper to their own compositing layers via [transform:translateZ(0)], so the GPU compositor honors stacking order. Compositing hint only — no layout, spacing, z-index, focus, or event-handling change.
  • Not a regression: every ingredient (the blur overlay + the calendar's sticky/z layers) has coexisted since the calendar first shipped (feat(scheduled-tasks): calendar views + persisted, runnable tasks #4979). The emcn extraction touched these files import-only; modal.tsx is byte-identical pre/post-move.

Type of Change

  • Bug fix

Testing

Tested manually. Note: this is a GPU-compositor behavior that is hard to reproduce deterministically headless — verified the reasoning via git archaeology and the isolated repro; needs a real-Mac eyeball that (1) the bleed is gone and (2) modal text stays crisp across a couple of modals.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@waleedlatif1
fix(emcn): promote modal overlay + content wrapper to own compositing…
52145ed 
… layers

The backdrop-blur overlay did not reliably paint above page content the
browser had GPU-promoted (position: sticky headers and z-indexed absolutes
inside a scroll container, e.g. the scheduled-tasks calendar), so those
composited layers bled through the overlay despite its higher z-index.
Force the overlay and the content wrapper onto their own compositing
layers via translateZ(0) so the compositor honors stacking order.

Inherent since the calendar shipped (#4979), not a refactor regression.
@vercel

vercel Bot commented Jul 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jul 1, 2026 3:47am

Request Review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cursor

cursor Bot commented Jul 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Low Risk
Import-only change in three modal files; behavior is limited to which React component backs the header icon.

Overview
Scheduled-task modals (TaskModal, TaskDetailsModal, TaskDeleteDialog) now import the Calendar glyph from @sim/emcn/icons instead of @sim/emcn, where the barrel explicitly resolves Calendar to the date-picker component.

ChipModalHeader still receives icon={Calendar}, but it is now the SVG icon rather than the full calendar grid—avoiding the wrong control being rendered in the header (and the compositing/visual issues that came with painting page-like calendar UI in the modal chrome).

Reviewed by Cursor Bugbot for commit 292891c. Bugbot is set up for automated code reviews on this repo. Configure here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the shared EMCN modal layering fix. The main changes are:

  • Adds a compositing hint to the modal backdrop.
  • Adds the same hint to the fixed modal content wrapper.
  • Documents why promoted calendar layers could bleed through the blurred backdrop.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
packages/emcn/src/components/modal/modal.tsx Adds translateZ(0) compositing hints to the modal overlay and fixed content wrapper without changing modal logic, focus handling, events, or sizing.

Reviews (1): Last reviewed commit: "fix(emcn): promote modal overlay + conte..." | Re-trigger Greptile
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vercel
vercel Bot deployed to Preview July 1, 2026 03:26
View deployment
TheodoreSpeaks added 3 commits June 30, 2026 20:42
@TheodoreSpeaks
Revert "fix(emcn): promote modal overlay + content wrapper to own com…
3cc1fcd 
…positing layers"

This reverts commit 52145ed.
@TheodoreSpeaks
fix(ui): import calendar icon not calendar widget from emcn
1ca1e63
@TheodoreSpeaks
fix(ui): fix calendar icon emcn mismatch
292891c
@vercel
vercel Bot temporarily deployed to Preview July 1, 2026 03:45 Inactive
@waleedlatif1
waleedlatif1 merged commit 44a954d into staging Jul 1, 2026
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
waleedlatif1 deleted the worktree-fix-scheduled-task-modal-overlay branch July 1, 2026 03:47
@waleedlatif1 waleedlatif1 mentioned this pull request Jul 1, 2026
v0.7.18: landing, tools depth, media embeds in md editor, sonnet 5 #5296
Merged

This branch was previously deployed

1 inactive deployment
Preview — 292891c9 Deployed Jul 1, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@waleedlatif1 @TheodoreSpeaks
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.