GeezerVison

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 5, 2026 5:39pm

PR Summary

Low Risk
Mechanical rename with unchanged durations and no auth or data-path logic changes; risk is limited to import/boundary mistakes, which CI checks are meant to catch.

Overview
Introduces a repo-wide React Query convention: every staleTime must come from a named exported constant (no inline millisecond literals), and server prefetch.ts helpers must import the same constant as the client hook for that query key so hydration and client reads never drift.

The rule is documented in sim-queries.md, root CLAUDE.md, and the react-query best-practices skill/commands. The change is applied mechanically across hooks/queries/** (~140 call sites) and six workspace prefetch.ts modules (files, home, knowledge, settings, tables, etc.), including in-hook prefetchQuery helpers. TABLE_LIST_STALE_TIME lives in non–'use client' utils/table-keys.ts so the tables page prefetch can import it safely.

No numeric staleTime values were changed; staleTime: 0 / Infinity idioms were left as-is.

^{Reviewed by Cursor Bugbot for commit 661efac. Configure here.}

Greptile Summary

This PR mechanically hoists every inline staleTime numeric literal in hooks/queries/** (~140 call sites across ~47 files) into a named exported constant, and updates the six server-side prefetch.ts consumers to import those constants instead of restating the number — eliminating the cache-drift hazard where a prefetch and its client hook could silently diverge.

• Core change: each query file now exports one constant per query type (e.g. LOG_DETAIL_STALE_TIME, TABLE_LIST_STALE_TIME); staleTime: 0 and staleTime: Infinity are intentionally left as literals since they are semantic idioms, not durations.
• Client-boundary split: TABLE_LIST_STALE_TIME is placed in the non-'use client' utils/table-keys.ts module (while TABLE_DETAIL_STALE_TIME etc. stay in the 'use client' tables.ts) so the server-side tables prefetch can import it without triggering the client-boundary guard.
• Documentation: the convention is codified in CLAUDE.md, .claude/rules/sim-queries.md, and the react-query-best-practices skill so future hooks will follow it from the start.

Confidence Score: 5/5

Pure rename/hoist refactor — no numeric values changed, no behavior change, TypeScript clean, client-boundary check passes.

Every changed line is a mechanical substitution of an inline literal with its newly-named constant; no query logic, fetch functions, or cache keys were touched. The tricky TABLE_LIST_STALE_TIME split across the client-boundary is handled correctly. The only residual gap is a handful of component files outside the stated scope that still carry inline literals duplicating the new constants, but that does not affect correctness of the change itself.

logs.tsx and knowledge-base-selector.tsx still carry inline staleTime literals that duplicate the new constants — worth a follow-up pass to extend the convention outside hooks/queries.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["hooks/queries/entity.ts\n(no 'use client')"] -->|"exports"| B["ENTITY_LIST_STALE_TIME = 60 * 1000"]
    A -->|"exports"| C["useEntityList hook"]
    B -->|"staleTime: ENTITY_LIST_STALE_TIME"| C
    D["app/.../prefetch.ts\n(server-side)"] -->|"imports"| B
    D -->|"staleTime: ENTITY_LIST_STALE_TIME"| E["queryClient.prefetchQuery"]

    subgraph special ["Client-boundary exception: tables"]
        F["hooks/queries/tables.ts\n('use client')"] -->|"imports TABLE_LIST_STALE_TIME"| G
        G["hooks/queries/utils/table-keys.ts\n(no 'use client')\nexports TABLE_LIST_STALE_TIME"]
        H["app/.../tables/prefetch.ts\n(server-side)"] -->|"imports TABLE_LIST_STALE_TIME"| G
    end

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["hooks/queries/entity.ts\n(no 'use client')"] -->|"exports"| B["ENTITY_LIST_STALE_TIME = 60 * 1000"]
    A -->|"exports"| C["useEntityList hook"]
    B -->|"staleTime: ENTITY_LIST_STALE_TIME"| C
    D["app/.../prefetch.ts\n(server-side)"] -->|"imports"| B
    D -->|"staleTime: ENTITY_LIST_STALE_TIME"| E["queryClient.prefetchQuery"]

    subgraph special ["Client-boundary exception: tables"]
        F["hooks/queries/tables.ts\n('use client')"] -->|"imports TABLE_LIST_STALE_TIME"| G
        G["hooks/queries/utils/table-keys.ts\n(no 'use client')\nexports TABLE_LIST_STALE_TIME"]
        H["app/.../tables/prefetch.ts\n(server-side)"] -->|"imports TABLE_LIST_STALE_TIME"| G
    end

_{Reviews (3): Last reviewed commit: "refactor(react-query): use FOLDER_LIST_S..." | Re-trigger Greptile}

@greptile

@cursor review

Addressed the folders.ts finding in 661efac — useFolders and useFolderMap now use the already-exported FOLDER_LIST_STALE_TIME instead of inline 60 * 1000 (same value, closes the last prefetch-drift gap). Re-running review.

@greptile

@cursor review