GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — fix(provenance): stop short secret values from rewriting unrelated long text by icecrasher321 · Pull Request #6416 · simstudioai/sim Conversation
Contributor
SummarySplit out detection vs render for projection to not over project. Type of Change
TestingTested manually Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
🛠 Guidelines to remediate hardcoded secrets
To avoid such incidents in the future consider
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
PR SummaryMedium Risk Overview This adds a length-based match policy module and a Reviewed by Cursor Bugbot for commit d5cc241. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Greptile SummaryThis PR separates detection from rendering and applies boundary-only projection to resolved secret values shorter than eight characters, preventing coincidental substitutions inside ordinary text.
Confidence Score: 3/5This PR is not safe to merge until embedded short active secrets are prevented from reaching Copilot and persisted trace outputs. The new render policy deliberately retains sub-eight-character secrets inside alphanumeric tokens, while model and trace projection paths—including trace invariant enforcement—use that same restricted policy. Files Needing Attention: apps/sim/lib/logs/execution/trace-secret-projection.ts, apps/sim/executor/utils/resolved-secret-content-projection.ts, apps/sim/executor/utils/resolved-secret-matcher.ts
|
| Filename | Overview |
|---|---|
| apps/sim/executor/utils/resolved-secret-match-policy.ts | Introduces the eight-character threshold and Unicode-aware boundary policy that intentionally suppresses embedded short matches. |
| apps/sim/executor/utils/resolved-secret-matcher.ts | Adds render policies and bounded repeated substitution; behavior is well tested, with a minor import-order violation. |
| apps/sim/executor/utils/resolved-secret-content-projection.ts | Applies render-mode matching to model and diagnostic projections, exposing the short-secret false-negative path. |
| apps/sim/lib/logs/execution/trace-secret-projection.ts | Uses the restricted matcher for both trace projection and invariant enforcement, allowing embedded short plaintext to survive into log sinks. |
| apps/sim/lib/copilot/request/tools/resolved-secret-result.test.ts | Explicitly demonstrates that a registered six-digit PIN remains visible when embedded in an alphanumeric token. |
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Active resolved-secret matches] --> B{Matcher mode}
B -->|detect| C[Match at any offset]
B -->|render| D{Secret length at least 8?}
D -->|yes| C
D -->|no| E{Word-boundary match?}
E -->|yes| F[Replace with provenance label]
E -->|no| G[Leave plaintext unchanged]
F --> H[Copilot or trace output]
G --> H
H --> I[Render-mode invariant check]
I -->|Same embedded match suppressed| H
Reviews (1): Last reviewed commit: "Merge commit '3b0651ed9c' into staging-v..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
d5cc241a
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.