GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — feat(search): page-aware cmd+k palette with ask-Sim mode by j15z · Pull Request #6518 · simstudioai/sim Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
PR SummaryMedium Risk Overview Tab toggles Ask Sim mode; Enter sends the query as a new chat via mothership handoff (or direct send when Home is already mounted), with persistence failure keeping the palette open. Page surfaces (tables, files, knowledge, logs, deploy) register palette-only global commands via Search ranking uses a deferred query, kebab-cased secondary tokens ( Shared CommandSearch / CommandFadedList chrome replaces ad-hoc cmdk layout in the palette and connection block selector; result rendering consolidates on SearchEntryGroup with richer row metadata and shortcut hints. Reviewed by Cursor Bugbot for commit 9ad2d36. Bugbot is set up for automated code reviews on this repo. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Greptile SummaryThe PR rebuilds the command palette around page-aware, globally ranked sections and adds Ask Sim handoff behavior.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; both previously reported deploy paths are guarded in the current code, and the barrel-export concern was resolved as an intentional local convention.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx | Rebuilds the palette around page-aware sections, unified ranking, and Ask Sim mode. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/utils.ts | Implements the search-entry model, ranking tiers, and action biases used by the palette. |
| apps/sim/app/workspace/[workspaceId]/providers/global-commands-provider.tsx | Extends global commands to support palette-only commands without keyboard shortcuts. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/deploy.tsx | Registers the deploy palette action and applies canonical permission, readiness, and registry-loading guards. |
| apps/sim/stores/modals/search/store.ts | Updates palette modal state and Ask Sim handoff behavior. |
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Input[Command palette input] --> Rank[Rank page-aware sections]
Rank --> Results[Unified result list]
Results --> Page[Open page or entity]
Results --> Action[Invoke registered page action]
Input -->|Tab| Ask[Ask Sim mode]
Ask -->|Enter| Home[Open Home with chat prefill]
Reviews (13): Last reviewed commit: "fix(deploy): use the emcn toast input sh..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c3b2738. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@j15z you can rebase this against staging, the base was merged into that |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
6d36494 to
5f8c15b
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 54aa354. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 575223d. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Carries the former merge resolutions as one commit: the emcn icon set (SelectAll fit-to-view, Search chrome), native browser-panel occlusion gating, scheduled-tasks retirement, the chip-aware handoff consumer superseding the ?handoff=1 machinery, and Knowledge bases pluralization.
Auto-send still loses the message on cross-route navigation — use-chat's cleanup abort fires during Home's mount-settling effect cycle. Prefill restored, but via LandingPromptStorage directly so free-form queries are never mentionified into @ chips.
Re-lands the auto-send flip: with fix/mship-mount-send-loss beneath this branch, sends started during Home's mount-settling window survive the cleanup abort (queued, restored, re-dispatched), so the handoff no longer loses the query on cross-route navigation.
- rank against a deferred query and hoist search-independent derivations so typing never blocks on the cross-section re-rank - cache secondary-text tokenization (hottest per-keystroke loop) - skip building browse groups mid-search; gate the palette-only credentials and logs queries on the palette being open - flatten getGlobalSearchResults onto a spec-stable sort - drop the dead store-side SEARCH_SECTIONS/docs path, the no-op CommandSearch surface variant, a duplicate hex regex, a dead font-base class, and the TaskItem/FolderedItem shape overlap
The frost under the floating input reused the canvas card's --surface-2 gradient, which reads as a tinted band on the palette's --surface-4/ --surface-5 dialog (visible in dark mode). The CommandSearch surface variant returns — this time with genuinely different values — and the chrome test pins the host-matching fog.
- table import command respects the in-progress upload gate - Export CSV is offered to viewers (matching the header control) - palette mode flips with the deferred query the ranking ran against - a gated palette deploy reports the button tooltip's reason via toast
b45f9d6 to
b39bb97
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b39bb97. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| handler: () => { | ||
| if (!userPermissions.canEdit || tableDataRef.current?.locks.insertLocked) return | ||
| onRequestImportCsv() | ||
| }, |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Medium Severity
table-import-csv still appears in the palette whenever canEdit is true, but the handler returns with no feedback when insertLocked is set. The header control is disabled for that lock, and the sibling table-new-column command already surfaces a blocked toast for schemaLocked, so a palette import on an insert-locked table looks selectable and then does nothing.
Reviewed by Cursor Bugbot for commit b39bb97. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| handler: () => { | ||
| if (!tableDataRef.current?.rowCount) return | ||
| void handleExportCsv() | ||
| }, |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Low Severity
table-export-csv is always offered on table detail, but the handler no-ops when rowCount is 0. The header Export control is disabled for empty tables, so the palette path gives no indication why nothing happened—the same class of silent failure the deploy action was later fixed to toast for.
Reviewed by Cursor Bugbot for commit b39bb97. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-Authored-By: Claude Fable 5 <[email protected]>
# Conflicts: # apps/sim/app/workspace/[workspaceId]/home/home.tsx # apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.mount-send.test.tsx # apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/panel.tsx # apps/sim/lib/core/utils/browser-storage.ts # apps/sim/lib/mothership/events.ts
There was an error while loading. Please reload this page.
9ad2d364
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.