GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — fix(knowledge): retain model input provenance by TheodoreSpeaks · Pull Request #6540 · simstudioai/sim Conversation
Contributor
Summary
Type of Change
Testing
Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
PR SummaryMedium Risk Overview
Regression tests cover Zod boundary parsing (envelope survives Reviewed by Cursor Bugbot for commit fff44fc. Bugbot is set up for automated code reviews on this repo. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Greptile SummaryThe PR fixes internal Knowledge Search parsing so authenticated private model-input provenance survives contract validation and reaches downstream provenance verification.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The internal schema now preserves the established provenance envelope, and the added tests cover both Zod retention and downstream authenticated provenance preparation without changing authorization or secret-exposure boundaries.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/api/contracts/knowledge/search.ts | Extends the internal request schema with the established optional resolved-secret provenance envelope while leaving the public search shape unchanged. |
| apps/sim/lib/api/contracts/knowledge/search.test.ts | Adds direct regression coverage proving that contract parsing retains the private provenance field. |
| apps/sim/lib/knowledge/model-input-provenance.test.ts | Adds coverage showing that a contract-parsed authenticated envelope initializes a complete provenance registry. |
sequenceDiagram
participant Tool as Internal workflow tool
participant Transport as Request transport
participant Contract as Knowledge request contract
participant Provenance as Provenance verifier
participant Search as Knowledge search
Tool->>Transport: Search body + resolved-secret registry
Transport->>Contract: Header + provenance envelope
Contract->>Contract: Parse and retain envelope
Contract->>Provenance: Parsed body and authenticated header
Provenance->>Search: Verified provenance registry
Reviews (1): Last reviewed commit: "fix(knowledge): retain model input prove..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
fff44fca
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.