GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(cmdk): update search-modal assertions to the renamed New chat label by waleedlatif1 · Pull Request #6549 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix/lowercase wording #6543 renamed the cmdk ask-Sim label to sentence case (New chat: ${query}, search-modal.tsx:1094) but left search-modal.test.tsx:152 and :195 asserting New Chat
  • Those two assertions have been failing Test and Build / Lint and Test on staging for every PR since, unrelated to whatever that PR changed
  • Test was stale, source is correct — updated the assertions to match

Type of Change

  • Bug fix

Testing

search-modal.test.tsx 19/19 pass. Confirmed the same 2 failures reproduce on clean origin/staging without this change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@waleedlatif1
fix(cmdk): update search-modal assertions to the renamed New chat label
1ca5c7c 
#6543 renamed the ask-Sim label to sentence case but left the two assertions
expecting 'New Chat', which has been failing Lint and Test on staging for
every PR since.
@vercel

vercel Bot commented Aug 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 11, 2026 6:20pm

Request Review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vercel
vercel Bot temporarily deployed to Preview August 11, 2026 18:20 Inactive
@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

PR Summary

Cursor Bugbot is generating a summary for commit 1ca5c7c. Configure here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
waleedlatif1 merged commit 2f1bb5a into staging Aug 11, 2026
22 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
waleedlatif1 deleted the fix/search-modal-new-chat-assertions branch August 11, 2026 18:21
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 11, 2026
v0.8.0: new workflow UI, v2 API, salesforce JWT, provenance improvements, incidentio tools, block retries #6533
Closed
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR corrects two stale SearchModal test assertions to match the existing sentence-case “New chat” label.

  • Updates the ask-mode label assertion for a Slack launch query.
  • Updates the corresponding assertion after keyboard mode switching.

Confidence Score: 5/5

The PR appears safe to merge because both test-only changes accurately reflect the existing production label.

The updated expectations match the hardcoded New chat: ${searchQuery} value rendered in ask mode, and no blocking or non-blocking defects remain.

Important Files Changed
Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.test.tsx Both assertions now match the production SearchModal label, with no actionable issues found.

Reviews (1): Last reviewed commit: "fix(cmdk): update search-modal assertion..." | Re-trigger Greptile
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 12, 2026
v0.8.0: desktop app, workflow UI, v2 endpoints #6606
Merged

This branch was previously deployed

1 inactive deployment
Preview — 1ca5c7c7 Deployed Aug 11, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@waleedlatif1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.