GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — improvement(audits): skip the sql-date-binding parse for files without drizzle-orm by waleedlatif1 · Pull Request #6554 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • check:sql-date-binding Babel-parsed all 13,941 source files under apps, packages, and scripts. A violation can only come from an sql tag resolved through a drizzle-orm import, and both the static (collectSqlBindings) and dynamic (isDrizzleImportCall) resolvers match the specifier as a string literal — so a file that never names the module cannot bind the tag and cannot violate.
  • Only ~590 of those files name it. Skip the parse for the other 92% of bytes.
  • Audit goes ~4.5s → ~0.8s (5.7x), dropping out of the four slowest audits. check:audits goes 6.0s → 5.3s wall, 38.0s → 32.9s serial.
  • Output is unchanged.

Type of Change

  • Improvement (performance)

Testing

Tested manually:

  • Clean tree before/after both report ✓ 13941 files bind every sql-template Date through a column encoder, warm timings 4.38s/4.63s → 0.82s/0.76s.
  • Planted a real violation (sql\... ${aDate}`in a file importingsqlfromdrizzle-orm`) and confirmed it is still reported with exit 1.
  • bun run check:audits and bunx biome check pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vercel

vercel Bot commented Aug 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 11, 2026 7:16pm

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

PR Summary

Cursor Bugbot is generating a summary for commit 38d5b01. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
improvement(audits): skip the sql-date-binding parse for files withou…
0ee302b
…t drizzle-orm

check:sql-date-binding Babel-parsed all 13,941 source files in apps, packages,
and scripts. A violation can only come from an `sql` tag resolved through a
`drizzle-orm` import, and both the static and dynamic resolvers match the
specifier as a string literal, so a file that never names the module cannot
produce one. Only ~590 files do.

Skipping the parse for the other 92% of bytes takes the audit from ~4.5s to
~0.8s and drops it out of the four slowest audits, taking check:audits from
6.0s to 5.3s wall and 38.0s to 32.9s serial. Output is unchanged.
@waleedlatif1
waleedlatif1 force-pushed the perf/audit-runtime branch from 38d5b01 to 0ee302b Compare August 11, 2026 19:09
@waleedlatif1

waleedlatif1 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

@cursor review

cursor[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@greptile-apps

greptile-apps Bot commented Aug 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR accelerates the SQL Date-binding audit by parsing only source files whose raw text names drizzle-orm.

  • Adds a lightweight mayBindDrizzleSql prefilter.
  • Reuses each file’s loaded source when invoking the existing analyzer.
  • Preserves violation detection for all current Drizzle imports in the repository.

Confidence Score: 5/5

The PR appears safe to merge because the new prefilter retains every currently reachable Drizzle SQL-binding analysis path.

The raw substring check includes all existing drizzle-orm import spellings in the repository, while skipped files cannot currently bind the audited SQL tag.

Important Files Changed

Filename Overview
scripts/check-sql-date-binding.ts Adds a conservative source-text prefilter before Babel parsing; no actionable defect was established for the repository’s current sources.

Reviews (2): Last reviewed commit: "improvement(audits): skip the sql-date-b..." | Re-trigger Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
waleedlatif1 merged commit 440a68b into staging Aug 11, 2026
22 of 23 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
waleedlatif1 deleted the perf/audit-runtime branch August 11, 2026 19:11
cursor[bot]
cursor Bot reviewed Aug 11, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0ee302b. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vercel
vercel Bot deployed to Preview August 11, 2026 19:16
View deployment
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 12, 2026
v0.8.0: desktop app, workflow UI, v2 endpoints #6606
Merged

This branch was successfully deployed

1 active deployment
Preview — 0ee302b4 Deployed Aug 11, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@waleedlatif1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.