GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||
GeezerVison is showing github.com — improvement(audits): skip the sql-date-binding parse for files without drizzle-orm by waleedlatif1 · Pull Request #6554 · simstudioai/sim Conversation
Collaborator
Summary
Type of Change
TestingTested manually:
Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR SummaryCursor Bugbot is generating a summary for commit 38d5b01. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…t drizzle-orm check:sql-date-binding Babel-parsed all 13,941 source files in apps, packages, and scripts. A violation can only come from an `sql` tag resolved through a `drizzle-orm` import, and both the static and dynamic resolvers match the specifier as a string literal, so a file that never names the module cannot produce one. Only ~590 files do. Skipping the parse for the other 92% of bytes takes the audit from ~4.5s to ~0.8s and drops it out of the four slowest audits, taking check:audits from 6.0s to 5.3s wall and 38.0s to 32.9s serial. Output is unchanged.
38d5b01 to
0ee302b
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Greptile SummaryThis PR accelerates the SQL Date-binding audit by parsing only source files whose raw text names
Confidence Score: 5/5The PR appears safe to merge because the new prefilter retains every currently reachable Drizzle SQL-binding analysis path. The raw substring check includes all existing
|
| Filename | Overview |
|---|---|
| scripts/check-sql-date-binding.ts | Adds a conservative source-text prefilter before Babel parsing; no actionable defect was established for the repository’s current sources. |
Reviews (2): Last reviewed commit: "improvement(audits): skip the sql-date-b..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0ee302b. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
0ee302b4
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.