GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||
GeezerVison is showing github.com — improvement(provenance): make the incompleteness reason set closed and complete by icecrasher321 · Pull Request #6559 · simstudioai/sim Conversation
Contributor
Summary
Also fixes a latent miss from #6513: the sweep passed a reason to the accumulator's zero-arg
Type of Change
TestingVerified every reason in the union now has at least one producer. Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
…d complete The reason a resolved-secret registry latched is the only thing that names which guard tripped, and a refusal surfaces many frames later as one fixed sentence. Two gaps had opened in that set. `workspace-scope-missing` no longer has a producer: the `!context.workspaceId` guard in the copilot table tool went away when `importRowsForModel` was rewritten, and every operation now returns early on a missing workspace before provenance import is reachable. The literal and its warn-classification test case go with it — the test constructed the reason itself, so it asserted on something nothing emits. ResolvedSecretTraceProvenanceAccumulator had no reason concept at all, so its three guards latched anonymously. That matters more there than on the registry: the wire format carries only `complete`, so the consumer can only ever say `source-provenance-incomplete`, and the guard is unrecoverable. Give it the same required `reason` and name all three — a file source with no workspace identity, a workspace file whose sidecar reads unknown, and an MCP tool that timed out. A latch from `record()` stays silent, since it reflects a bundle whose own registry already reported and subflow aggregation runs it per iteration. Fold the error/warn/by-design split into one `reportIncompleteness`. It was copied across both registry latches and would have been copied a third time here, and a copy that can be updated alone lets one reason be a fault in one place and routine in another. Also give the async workflow tool path its own import origin instead of latching with none, and close `UnrecordedDurableProvenanceCause`, which was a free-form string carrying a TSDoc claim that it was always a static literal.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
PR SummaryLow Risk Overview
Also removes the dead Reviewed by Cursor Bugbot for commit ef686fa. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Greptile SummaryThe PR closes and completes provenance-reason types while adding actionable diagnostics for accumulator guards.
Confidence Score: 5/5The PR appears safe to merge with no concrete correctness, security, or compatibility failures identified. The reason-set changes cover all current producers, reporting retains existing classification and suppression behavior, and accumulator provenance remains fail-closed while gaining bounded diagnostics.
|
| Filename | Overview |
|---|---|
| apps/sim/executor/utils/resolved-secret-trace-registry.ts | Centralizes incompleteness reporting, extends the closed reason union, and adds first-guard accumulator diagnostics without changing fail-closed provenance semantics. |
| apps/sim/app/api/mcp/tools/execute/route.ts | Names MCP execution timeouts when they make accumulated provenance incomplete. |
| apps/sim/app/api/tools/file/manage/route.ts | Assigns distinct reasons to unidentified file sources and unknown workspace-file provenance. |
| apps/sim/lib/copilot/request/tools/client.ts | Adds one stable origin to asynchronous workflow provenance import failures and incomplete bundles. |
| apps/sim/lib/execution/durable-secret-provenance-enforcement.ts | Replaces a free-form report cause with a union containing every current production cause. |
| apps/sim/executor/utils/resolved-secret-trace-registry.test.ts | Updates reason classification coverage and verifies first-guard reporting and silent imported-bundle latching. |
Reviews (1): Last reviewed commit: "improvement(provenance): make the incomp..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
ef686fac
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.