GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||
GeezerVison is showing github.com — fix(mship, desktop): fix bugs by Sg312 · Pull Request #6572 · simstudioai/sim Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Greptile SummaryThis PR revises desktop release streams and update handling, fixes Copilot abort ordering, and adjusts Mothership interaction rendering. It also removes desktop folder-management controls while persistent filesystem grants remain active.
Confidence Score: 3/5The PR should not merge until users retain an in-app way to inspect and revoke persistent local-folder access. Existing filesystem grants survive restarts and remain available to Copilot tools, while this change removes the sole settings UI that listed and revoked them; the new route test also violates the repository’s absolute-import convention. Files Needing Attention: apps/sim/app/workspace/[workspaceId]/settings/components/desktop/desktop.tsx; apps/sim/app/api/desktop/update/latest-mac.yml/route.test.ts
|
| Filename | Overview |
|---|---|
| apps/desktop/src/main/updater.ts | Reworks update-channel resolution, feed probing, candidate validation, timeouts, and explicit download-to-install behavior; no confirmed blocking updater defect remains. |
| apps/sim/app/api/desktop/update/latest-mac.yml/route.ts | Selects update streams from the request hostname, distinguishes authoritative no-release responses, and validates manifest versions against release tags. |
| apps/sim/app/api/copilot/chat/abort/route.ts | Moves the bounded Go abort-marker request before local SSE teardown to prevent deliberate stops from being misclassified. |
| apps/sim/app/workspace/[workspaceId]/settings/components/desktop/desktop.tsx | Simplifies desktop settings but removes the only UI for inspecting and revoking persistent local filesystem grants. |
| apps/sim/app/api/desktop/update/latest-mac.yml/route.test.ts | Adds update-feed coverage but introduces a relative import contrary to the apps/sim absolute-import rule. |
| apps/sim/app/workspace/[workspaceId]/home/components/mothership-chat/mothership-chat.tsx | Marks superseded credential interactions as abandoned so historical prompts render as recaps instead of active forms. |
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Shell[Desktop shell] --> Feed[Environment update feed]
Feed --> Release[Matching dev, staging, or stable release]
Release --> Updater[Desktop updater]
Updater --> Download[Download update]
Download --> Install[Install and relaunch]
User[User grants local folder] --> Store[Persistent encrypted grant store]
Store --> Restore[Restore grant at startup]
Restore --> Tools[Copilot filesystem tools]
Settings[Desktop settings] -. no revoke control .-> Store
Reviews (1): Last reviewed commit: "fix bugs" | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
2f908894
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.