GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — improvement(desktop, executions): fix desktop update script and throw error when thinking enabled on stream false by Sg312 · Pull Request #6578 · simstudioai/sim

Conversation

@Sg312

@Sg312 Sg312 commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

Fix desktop update script and throw error when thinking enabled on stream false

Type of Change

  • Bug fix

Testing

Manual

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Sg312 added 2 commits August 11, 2026 18:22
@Sg312
Fix update check
1ee4d14
@Sg312
fix include tool calls error
d8fcca5
@vercel

vercel Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 12, 2026 1:41am

Request Review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Sg312 Sg312 changed the title Improvement desktop 3 improvement(desktop, executions): fix desktop update script and throw error when thinking enabled on stream false Aug 12, 2026
@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR tightens workflow-execution validation for agent-event options and improves desktop update-channel resolution behind reverse proxies.

  • Requires stream: true when requesting thinking or tool-call events and updates the OpenAPI contract.
  • Uses the forwarded public hostname to select dev, staging, or stable desktop update feeds.
  • Adds focused route tests for both behaviors.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking recommendation to avoid trusting forwarded hostnames unless the deployment guarantees they are sanitized by a trusted proxy.

The workflow validation and generated contract are coordinated, while desktop channel selection can silently skip origin updates in deployments that preserve or supply an incorrect forwarded hostname.

Files Needing Attention: apps/sim/app/api/desktop/update/latest-mac.yml/route.ts

Important Files Changed
Filename Overview
apps/sim/app/api/desktop/update/latest-mac.yml/route.ts Adds forwarded-host-based update-channel selection, but assumes the first forwarded hostname is trustworthy.
apps/sim/app/api/desktop/update/latest-mac.yml/route.test.ts Adds coverage for forwarded public hostnames and Host-header fallback across release channels.
apps/sim/app/api/v2/workflows/[id]/execute/route.ts Rejects agent-event options outside streaming mode before validating the stream protocol header.
apps/sim/lib/api/contracts/v2/workflows.ts Centralizes documentation of the new stream requirement in the shared execution constraints.
apps/sim/lib/api/contracts/v2/openapi/workflows.ts Reuses the shared execution-constraint text in the workflow operation description.
apps/docs/openapi-v2-workflows.json Regenerates the public OpenAPI document with the new stream-only option constraint.

Reviews (1): Last reviewed commit: "fix include tool calls error" | Re-trigger Greptile
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot]
greptile-apps Bot reviewed Aug 12, 2026
View reviewed changes
Comment thread apps/sim/app/api/desktop/update/latest-mac.yml/route.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vercel
vercel Bot deployed to Preview August 12, 2026 01:35
View deployment
@Sg312
fix comments
c9a8320
@vercel
vercel Bot temporarily deployed to Preview August 12, 2026 01:41 Inactive
@Sg312
Sg312 merged commit 7f39678 into staging Aug 12, 2026
28 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
waleedlatif1 deleted the improvement-desktop-3 branch August 12, 2026 02:57
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 12, 2026
v0.8.0: desktop app, workflow UI, v2 endpoints #6606
Merged

This branch was previously deployed

1 inactive deployment
Preview — c9a83204 Deployed Aug 12, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Sg312
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.