GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — fix(security): redact workflow snapshot secrets by TheodoreSpeaks · Pull Request #6581 · simstudioai/sim Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
PR SummaryHigh Risk Overview
This hardened projection is applied to v1/v2 execution logs and v2 workflow version reads, with OpenAPI/contract descriptions updated to match. Reviewed by Cursor Bugbot for commit ff82280. Bugbot is set up for automated code reviews on this repo. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Greptile SummaryThe PR hardens public workflow snapshots by using shared tool-parameter codecs and withholding values whose safety cannot be authoritatively classified.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/workflows/credentials/credential-extractor.ts | Adds fail-closed recursive sanitization for tool inputs, opaque tables, credential references, and malformed parameter shapes. |
| apps/sim/lib/workflows/search-replace/indexer.ts | Exposes parameter-authority metadata and prevents custom or MCP tool identifiers from resolving as registered built-ins. |
| apps/sim/lib/logs/snapshot-sanitizer.ts | Enables opaque credential-input redaction for retained execution snapshots. |
| apps/sim/lib/workflows/application/read-workflow-version.ts | Applies the same hardened workflow projection to version-detail responses. |
| apps/sim/lib/workflows/search-replace/indexer.test.ts | Verifies generic and colliding custom/MCP parameters remain non-authoritative. |
| apps/sim/lib/workflows/credentials/credential-extractor.test.ts | Covers sensitive, safe, opaque, malformed, and unclassified sanitizer behavior. |
Reviews (5): Last reviewed commit: "fix(security): isolate opaque tool schem..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
5f18904 to
dde3fb8
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
dde3fb8 to
e2842f6
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e2842f6. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
e2842f6 to
56ab7d0
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 56ab7d0. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
56ab7d0 to
ff82280
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ff82280. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
ff822805
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.