GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||
GeezerVison is showing github.com — fix(tables): cap row pages and use native cursors by TheodoreSpeaks · Pull Request #6582 · simstudioai/sim Conversation
Contributor
Summary
Type of Change
Testing
Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
PR SummaryMedium Risk Overview v2 Reviewed by Cursor Bugbot for commit d0d3a42. Bugbot is set up for automated code reviews on this repo. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Greptile SummaryThe PR changes v2 table-row listing to pass native storage cursors through the API and enables a default 5MB cap for bounded row pages.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/table/application/rows.ts | Replaces offset-based v2 listing with validated native cursor pagination and passes the service cursor through unchanged. |
| apps/sim/lib/table/rows/service.ts | Applies the configured byte cap to every bounded row query while retaining fail-fast behavior for unbounded queries. |
| apps/sim/lib/table/constants.ts | Makes the bounded-page byte budget default to the existing 5MB query-result limit. |
| apps/sim/app/api/v2/tables/[tableId]/rows/route.ts | Passes opaque cursors to the application layer and directly presents its native continuation cursor. |
| apps/sim/lib/api/contracts/v2/openapi/tables.ts | Documents that byte-bounded pages can be short and clients must continue until nextCursor is null. |
Reviews (2): Last reviewed commit: "fix(tables): cap row pages and use nativ..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
978b2d9 to
d0d3a42
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d0d3a42. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
d0d3a429
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.