GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(tables): cap row pages and use native cursors by TheodoreSpeaks · Pull Request #6582 · simstudioai/sim

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • cap bounded table row pages at 5MB by default
  • use native table-row cursors for v2 row pagination
  • reject malformed cursors and document short-page behavior

Type of Change

  • Bug fix

Testing

  • 92 focused tests passing
  • full lint passing
  • all 25 CI audits passing
  • OpenAPI validation passing

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vercel

vercel Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 12, 2026 2:20am

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cursor

cursor Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes default pagination behavior for table row APIs (short pages by byte budget) and switches list-rows cursor encoding, which can break clients that stop on page fullness or expect offset-based cursors.

Overview
Bounded row pages now default to a 5MB byte budget, so list/query responses may return fewer rows than the requested limit. Clients must keep paging until nextCursor is null. TABLE_MAX_PAGE_BYTES remains overridable.

v2 GET /tables/{tableId}/rows now passes opaque native keyset cursors through instead of encoding/decoding offset cursors. Malformed cursors are rejected, and OpenAPI docs call out the short-page behavior.

Reviewed by Cursor Bugbot for commit d0d3a42. Bugbot is set up for automated code reviews on this repo. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR changes v2 table-row listing to pass native storage cursors through the API and enables a default 5MB cap for bounded row pages.

  • Moves cursor decoding and validation into the authorized table-row application use case.
  • Returns the native nextCursor produced by row storage pagination.
  • Defaults bounded row pages to a configurable 5MB byte budget.
  • Updates tests, API contracts, and OpenAPI documentation for short-page behavior.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/lib/table/application/rows.ts Replaces offset-based v2 listing with validated native cursor pagination and passes the service cursor through unchanged.
apps/sim/lib/table/rows/service.ts Applies the configured byte cap to every bounded row query while retaining fail-fast behavior for unbounded queries.
apps/sim/lib/table/constants.ts Makes the bounded-page byte budget default to the existing 5MB query-result limit.
apps/sim/app/api/v2/tables/[tableId]/rows/route.ts Passes opaque cursors to the application layer and directly presents its native continuation cursor.
apps/sim/lib/api/contracts/v2/openapi/tables.ts Documents that byte-bounded pages can be short and clients must continue until nextCursor is null.

Reviews (2): Last reviewed commit: "fix(tables): cap row pages and use nativ..." | Re-trigger Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot]
greptile-apps Bot reviewed Aug 12, 2026
View reviewed changes
Comment thread apps/sim/lib/table/application/rows.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TheodoreSpeaks
fix(tables): cap row pages and use native cursors
d0d3a42
@TheodoreSpeaks
TheodoreSpeaks force-pushed the feat/investigate-table-issues branch from 978b2d9 to d0d3a42 Compare August 12, 2026 02:15
@TheodoreSpeaks

TheodoreSpeaks commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TheodoreSpeaks

TheodoreSpeaks commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

cursor[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vercel
vercel Bot deployed to Preview August 12, 2026 02:20
View deployment
cursor[bot]
cursor Bot reviewed Aug 12, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit d0d3a42. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@TheodoreSpeaks
TheodoreSpeaks merged commit 9f3c202 into staging Aug 12, 2026
30 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@TheodoreSpeaks
TheodoreSpeaks deleted the feat/investigate-table-issues branch August 12, 2026 02:24
This was referenced Aug 12, 2026
v0.8.0: desktop app, workflow UI, v2 endpoints #6606
Merged
fix(tables): stop every table paginating forever on a null totalCount #6694
Merged

This branch was successfully deployed

1 active deployment
Preview — d0d3a429 Deployed Aug 12, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cursor cursor[bot] cursor[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@TheodoreSpeaks
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.