GeezerVison

Summary

• Collapse the two internal error envelopes into one. internalOrchestrationErrorPolicy emitted { success: false, error } and internalPlainOrchestrationErrorPolicy emitted { error }; both now emit { error } under the single internalOrchestrationErrorPolicy name.
• The split approximated pre-builder behavior, where the shape depended on which branch failed — guard clauses returned { error } and a route's terminal try/catch returned { success: false, error }. A per-route policy cannot express a per-branch rule, so the two variants disagreed on the same status across families.
• Kept the bare shape because it is what messageFromErrorBody reads on the client and what most migrated routes already emitted. requestJson throws ApiClientError for any non-2xx, so no typed client ever observes the discriminator.
• Restore requestId to internal error bodies. withRouteHandler stamps it on the bodies it generates, but the builder overrides dropped it, leaving it only on the x-request-id header — invisible when a user pastes an error out of the UI.
• Applied at the createJsonErrorResponse chokepoint plus both wrapper overrides, in the JSON and binary builders. Omitted when there is no active request scope, so unit tests are unaffected unless they opt in.
• Dropped the now-redundant internalFileErrorPolicies.plain alias.

success: true on success bodies is a separate contract and is untouched — /files/[fileId]/dimensions still returns a { success: false } domain result at 200.

Internal routes only. No /api/v1/** route changes shape.

Type of Change

• Bug fix

Testing

bun run type-check clean. 3118 API tests pass (app/api + lib/api). bun run check:api-validation passes.

Added lib/api/server/routes/request-id.test.ts and a builder test pinning the bare envelope. Verified both go red when the injection is reverted.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)