GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(tables): prevent legacy group auto-run dispatch by TheodoreSpeaks · Pull Request #6595 · simstudioai/sim

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • only dispatch table group auto-run on an explicit false-to-true transition
  • add regression coverage for legacy groups without a persisted autoRun value

Type of Change

  • Bug fix

Testing

  • targeted Vitest suite
  • TypeScript type-check
  • lint and full audit suite

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@TheodoreSpeaks
fix(tables): prevent legacy group auto-run dispatch
6bd9537
@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 12, 2026 4:27am

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cursor

cursor Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes when background workflow auto-runs are dispatched for table groups, which can affect unintended job execution. The fix is narrowly scoped and more conservative than the previous behavior.

Overview
Prevents unintended auto-run when updating legacy table groups that lack a persisted autoRun field.

updateTableGroupUseCase and updateWorkflowTableGroup now set startAutoRun only on an explicit false → true transition (previousGroup.autoRun === false), instead of treating any non-true prior value (including undefined) as a newly enabled toggle.

Adds regression tests covering both update paths for legacy enabled groups.

Reviewed by Cursor Bugbot for commit 6bd9537. Bugbot is set up for automated code reviews on this repo. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR narrows table-group auto-run dispatch to explicit false-to-true transitions so saving legacy groups with no persisted autoRun value does not start execution.

  • Updates both generic and workflow-specific group update commands.
  • Adds regression tests for legacy groups whose autoRun property is absent.

Confidence Score: 4/5

The PR appears safe to merge, with only a non-blocking gap in coverage for explicitly enabling a disabled group.

The implementation consistently prevents legacy undefined-to-true saves from dispatching while retaining explicit false-to-true behavior, but the added tests exercise only the suppression side of that contract.

Files Needing Attention: apps/sim/lib/table/application/groups.test.ts

Important Files Changed

Filename Overview
apps/sim/lib/table/application/groups.ts Correctly restricts both update paths to explicit false-to-true auto-run transitions.
apps/sim/lib/table/application/groups.test.ts Covers legacy absent-value suppression but omits positive coverage preserving explicit false-to-true dispatch.

Reviews (1): Last reviewed commit: "fix(tables): prevent legacy group auto-r..." | Re-trigger Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot]
greptile-apps Bot reviewed Aug 12, 2026
View reviewed changes
Comment thread apps/sim/lib/table/application/groups.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TheodoreSpeaks
TheodoreSpeaks merged commit 9923faf into staging Aug 12, 2026
30 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@TheodoreSpeaks
TheodoreSpeaks deleted the fix/table-cascade branch August 12, 2026 04:32
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 12, 2026
v0.8.0: desktop app, workflow UI, v2 endpoints #6606
Merged

This branch was previously deployed

1 inactive deployment
Preview — 6bd95379 Deployed Aug 12, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@TheodoreSpeaks
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.