GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — fix(knowledge): return pending status for new documents by TheodoreSpeaks · Pull Request #6597 · simstudioai/sim Conversation
Contributor
Summary
Type of Change
Testing
Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit 526ea5e. Bugbot is set up for automated code reviews on this repo. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Greptile SummaryThe PR aligns newly created knowledge-document return types and API responses with the persisted
Confidence Score: 5/5The PR appears safe to merge with the creation result, persisted state, orchestration types, and route response consistently aligned. Newly created documents return the pending state written to storage, while idempotent lookups retain later persisted lifecycle states without changing queue or retry behavior.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/knowledge/documents/service.ts | Returns the newly persisted pending status and correctly widens idempotent lookups to the complete persisted status union. |
| apps/sim/lib/knowledge/orchestration/documents.ts | Aligns the created-document contract with new pending documents and existing documents returned in later lifecycle states. |
| apps/sim/app/api/knowledge/migrated-routes.test.ts | Updates the creation fixture and verifies that the migrated route returns pending status. |
| apps/sim/lib/knowledge/documents/storage-billing.test.ts | Verifies that single-document creation both persists and returns pending status. |
Reviews (1): Last reviewed commit: "fix(knowledge): return pending status fo..." | Re-trigger Greptile
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
526ea5e1
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.