GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(knowledge): return pending status for new documents by TheodoreSpeaks · Pull Request #6597 · simstudioai/sim

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return the persisted pending status for newly created knowledge documents
  • keep created-document types and route responses aligned with the response contract

Type of Change

  • Bug fix

Testing

  • 27 focused Vitest tests
  • Sim type-check
  • lint and repository audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@TheodoreSpeaks
fix(knowledge): return pending status for new documents
526ea5e
@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 12, 2026 4:36am

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cursor

cursor Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Low Risk
Narrow typing and return-value fix for document creation; no auth, billing, or processing pipeline behavior changes.

Overview
Ensures newly created knowledge documents return and persist processingStatus: 'pending', aligning the create response with the actual DB state.

createSingleDocument now includes processingStatus in both the inserted row and its return type. Downstream CreatedKnowledgeDocument typing makes the field required (still allowing later states on idempotent upload completion), and tests assert the create-document API returns pending.

Reviewed by Cursor Bugbot for commit 526ea5e. Bugbot is set up for automated code reviews on this repo. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR aligns newly created knowledge-document return types and API responses with the persisted pending processing state.

  • Adds processingStatus: 'pending' to the single-document creation result.
  • Widens idempotent lookup and orchestration types to represent later persisted processing states.
  • Updates focused service and migrated-route tests to verify the pending response contract.

Confidence Score: 5/5

The PR appears safe to merge with the creation result, persisted state, orchestration types, and route response consistently aligned.

Newly created documents return the pending state written to storage, while idempotent lookups retain later persisted lifecycle states without changing queue or retry behavior.

Important Files Changed

Filename Overview
apps/sim/lib/knowledge/documents/service.ts Returns the newly persisted pending status and correctly widens idempotent lookups to the complete persisted status union.
apps/sim/lib/knowledge/orchestration/documents.ts Aligns the created-document contract with new pending documents and existing documents returned in later lifecycle states.
apps/sim/app/api/knowledge/migrated-routes.test.ts Updates the creation fixture and verifies that the migrated route returns pending status.
apps/sim/lib/knowledge/documents/storage-billing.test.ts Verifies that single-document creation both persists and returns pending status.

Reviews (1): Last reviewed commit: "fix(knowledge): return pending status fo..." | Re-trigger Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TheodoreSpeaks
TheodoreSpeaks merged commit 326cb94 into staging Aug 12, 2026
30 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@TheodoreSpeaks
TheodoreSpeaks deleted the fix/knowledge-single-document-processing-status branch August 12, 2026 04:41
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 12, 2026
v0.8.0: desktop app, workflow UI, v2 endpoints #6606
Merged

This branch was previously deployed

1 inactive deployment
Preview — 526ea5e1 Deployed Aug 12, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@TheodoreSpeaks
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.