GeezerVison is showing github.com — chore(ci): declare least-privilege permissions on the desktop e2e workflow by waleedlatif1 · Pull Request #6622 · simstudioai/sim
Conversation
Summary
- Add a top-level
permissions: contents: read block to .github/workflows/desktop-e2e.yml — it was the only workflow in the repo without one, so both its jobs inherited the repo-default GITHUB_TOKEN scope
- Closes CodeQL alerts refactor: use chonkie locally #474 and refactor: use chonkie locally #475 ("Workflow does not contain permissions", Medium)
- Matters most for the
latest canary leg, which runs bun add -d electron@latest and pulls an unpinned dependency tree onto the runner
Type of Change
Testing
Tested manually — the workflow is workflow_dispatch-only and neither job reads secrets.GITHUB_TOKEN beyond checkout, so read-only is sufficient
Checklist
- Code follows project style guidelines
- Self-reviewed my changes
- Tests added/updated and passing
- No new warnings introduced
- I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
vercel
Bot
commented
Aug 12, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cursor
Bot
commented
Aug 12, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
Low Risk
CI-only hardening that narrows token scope; no application or runtime behavior changes.
Overview
Adds a workflow-level permissions: contents: read block to .github/workflows/desktop-e2e.yml, matching other repo workflows and closing CodeQL “workflow does not contain permissions” findings.
Both jobs (e2e with pinned/electron@latest canary, and package-smoke) previously inherited the repository default GITHUB_TOKEN scope; read-only is enough for checkout, Bun/Playwright runs, and failure artifact uploads.
Reviewed by Cursor Bugbot for commit bf4241c. Configure here.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Greptile Summary
This PR applies least-privilege token access to the manually dispatched desktop E2E workflow.
- Adds a workflow-level
contents: read permission.
- Preserves sufficient access for repository checkout without granting unnecessary write scopes.
Confidence Score: 5/5
The PR appears safe to merge with no actionable issues identified.
The workflow only needs read access to check out repository contents, while its remaining setup, test, packaging, and artifact operations do not require broader GITHUB_TOKEN repository permissions.
Important Files Changed
| Filename |
Overview |
| .github/workflows/desktop-e2e.yml |
Adds an appropriate read-only repository permission without disrupting the workflow’s checkout, test, packaging, or artifact-upload steps. |
Reviews (1): Last reviewed commit: "chore(ci): declare least-privilege permi..." | Re-trigger Greptile
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This branch was successfully deployed
1 active
deployment
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|