GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore(ci): declare least-privilege permissions on the desktop e2e workflow by waleedlatif1 · Pull Request #6622 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a top-level permissions: contents: read block to .github/workflows/desktop-e2e.yml — it was the only workflow in the repo without one, so both its jobs inherited the repo-default GITHUB_TOKEN scope
  • Closes CodeQL alerts refactor: use chonkie locally #474 and refactor: use chonkie locally #475 ("Workflow does not contain permissions", Medium)
  • Matters most for the latest canary leg, which runs bun add -d electron@latest and pulls an unpinned dependency tree onto the runner

Type of Change

  • Chore / CI hardening

Testing

Tested manually — the workflow is workflow_dispatch-only and neither job reads secrets.GITHUB_TOKEN beyond checkout, so read-only is sufficient

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vercel

vercel Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 12, 2026 4:38pm

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cursor

cursor Bot commented Aug 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Low Risk
CI-only hardening that narrows token scope; no application or runtime behavior changes.

Overview
Adds a workflow-level permissions: contents: read block to .github/workflows/desktop-e2e.yml, matching other repo workflows and closing CodeQL “workflow does not contain permissions” findings.

Both jobs (e2e with pinned/electron@latest canary, and package-smoke) previously inherited the repository default GITHUB_TOKEN scope; read-only is enough for checkout, Bun/Playwright runs, and failure artifact uploads.

Reviewed by Cursor Bugbot for commit bf4241c. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR applies least-privilege token access to the manually dispatched desktop E2E workflow.

  • Adds a workflow-level contents: read permission.
  • Preserves sufficient access for repository checkout without granting unnecessary write scopes.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The workflow only needs read access to check out repository contents, while its remaining setup, test, packaging, and artifact operations do not require broader GITHUB_TOKEN repository permissions.

Important Files Changed

Filename Overview
.github/workflows/desktop-e2e.yml Adds an appropriate read-only repository permission without disrupting the workflow’s checkout, test, packaging, or artifact-upload steps.

Reviews (1): Last reviewed commit: "chore(ci): declare least-privilege permi..." | Re-trigger Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vercel
vercel Bot deployed to Preview August 12, 2026 16:19
View deployment
@waleedlatif1
chore(ci): declare least-privilege permissions on the desktop e2e wor…
a902a5b
…kflow
@waleedlatif1
waleedlatif1 force-pushed the worktree-codeql-workflow-permissions branch from bf4241c to a902a5b Compare August 12, 2026 16:31
@waleedlatif1
waleedlatif1 merged commit 878856b into staging Aug 12, 2026
20 of 21 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
waleedlatif1 deleted the worktree-codeql-workflow-permissions branch August 12, 2026 16:33
@vercel
vercel Bot deployed to Preview August 12, 2026 16:38
View deployment
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 12, 2026
v0.8.1: grok 4.6, v2 endpoints extension, workflow UI improvements, logrocket, perf improvements #6646
Merged

This branch was successfully deployed

1 active deployment
Preview — a902a5bc Deployed Aug 12, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@waleedlatif1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.