GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — improvement(forking): hide satisfied dependent configuration by icecrasher321 · Pull Request #6723 · simstudioai/sim

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Aug 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

  • Hide unchanged dependent selectors that are already satisfied while keeping workflow usage visible.
  • Reveal provider chains for fields that need configuration and clear every transitive descendant when a provider is re-picked, preventing stored IDs from leaking into the sync payload.
  • Build selector context with persisted canonical modes so advanced-mode dependencies use the active value.
  • Cover top-level blocks and tools nested in Agent blocks.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation update

Testing

  • bun run type-check
  • bun run lint
  • bun run check:audits
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging
  • All 37 workspace-forking Vitest suites: 549 tests passed

Checklist

  • Tests added or updated
  • Docs updated if needed
  • No secrets committed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Vikhyath Mondreti
fix(forking): hide satisfied dependent configuration
0df2ce3
@vercel

vercel Bot commented Aug 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 15, 2026 5:13am

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cursor

cursor Bot commented Aug 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes fork-sync UI gating and in-session reconfig state that feeds the sync payload; behavior is well covered by tests but incorrect gating could block sync or send stale dependent IDs.

Overview
Fork sync only surfaces dependent selectors that still need user action, instead of listing every dependent whenever a resource is mapped.

When the parent mapping is unchanged and stored values are already valid, satisfied required and optional dependents stay hidden; workflows that only use the resource with nothing to configure still appear in a muted “nothing to configure there” note. If a child still needs a value, upstream provider fields in the same block are shown too so the user can see and change the scoping context.

Re-picking a provider now clears every transitive descendant in-session (empty overrides), not just direct children, so stale stored IDs do not leak into the sync payload after a parent in the chain changes.

Dependent selector context during collection now respects persisted canonical modes (e.g. advanced projectId), so downstream selectors query with the active value rather than a stale basic-mode field.

Reviewed by Cursor Bugbot for commit c761851. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@greptile-apps

greptile-apps Bot commented Aug 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR reduces workspace-fork configuration noise while preserving selectors needed to configure required dependent chains.

  • Classifies dependent selectors as actionable based on parent resolution, mapping changes, copy state, and missing required values.
  • Retains transitive context providers whenever a descendant requires configuration.
  • Applies the filtered presentation to top-level block fields and fields nested under Agent tools.
  • Adds focused tests for selector visibility and transitive provider inclusion.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/ee/workspace-forking/components/fork-sync/dependent-value.ts Adds actionable-field classification and transitive context-provider expansion.
apps/sim/ee/workspace-forking/components/fork-sync/fork-sync-view.tsx Filters rendered dependent selectors per mapping state while preserving workflow usage grouping.
apps/sim/ee/workspace-forking/components/fork-sync/dependent-value.test.ts Covers visibility rules and direct and transitive provider inclusion.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Dependent field] --> B{Parent resolved?}
  B -- No --> H[Hide selector]
  B -- Yes --> C{Parent changed or copied?}
  C -- Yes --> S[Show selector]
  C -- No --> D{Required value missing?}
  D -- Yes --> S
  D -- No --> H
  S --> P[Include transitive context providers]
Loading

Reviews (2): Last reviewed commit: "fix(forking): keep dependent chains conf..." | Re-trigger Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor[bot]
cursor Bot reviewed Aug 15, 2026
View reviewed changes
Comment thread apps/sim/ee/workspace-forking/components/fork-sync/dependent-value.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@icecrasher321 icecrasher321 changed the title fix(forking): hide satisfied dependent configuration improvement(forking): hide satisfied dependent configuration Aug 15, 2026
Vikhyath Mondreti
fix(forking): keep dependent chains configurable
6b86486
@vercel
vercel Bot temporarily deployed to Preview August 15, 2026 04:46 Inactive
@icecrasher321

icecrasher321 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

bugbot run

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@icecrasher321

icecrasher321 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor[bot]
cursor Bot reviewed Aug 15, 2026
View reviewed changes
Comment thread apps/sim/ee/workspace-forking/components/fork-sync/dependent-value.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Vikhyath Mondreti
fix(forking): invalidate stale dependent selectors
c761851
@vercel
vercel Bot temporarily deployed to Preview August 15, 2026 05:13 Inactive
@icecrasher321 icecrasher321 changed the title improvement(forking): hide satisfied dependent configuration fix(forking): hide satisfied dependent configuration Aug 15, 2026
@icecrasher321

icecrasher321 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

cursor[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor[bot]
cursor Bot reviewed Aug 15, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit c761851. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@icecrasher321
icecrasher321 enabled auto-merge (squash) August 16, 2026 01:36
@icecrasher321
icecrasher321 merged commit be20df9 into staging Aug 16, 2026
30 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@icecrasher321 icecrasher321 changed the title fix(forking): hide satisfied dependent configuration improvement(forking): hide satisfied dependent configuration Aug 16, 2026
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 16, 2026
v0.8.3: sim cli, new tools, credential groups, splunk, finder-like files refactor, security hardening #6765
Merged
@waleedlatif1
waleedlatif1 deleted the codex/fork-dependent-config-ux branch August 16, 2026 08:23

This branch was previously deployed

1 inactive deployment
Preview — c7618516 Deployed Aug 15, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@icecrasher321
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.