GeezerVison

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 15, 2026 11:52pm

PR Summary

Medium Risk
Large interaction-state changes in the main table grid (debounce, placeholder data, paging, selection) could cause edge-case navigation bugs, but there is no change to auth, persistence APIs, or data writes beyond existing find/row fetch behavior.

Overview
Reworks table Cmd+F so the search runs on a debounced trimmed query (not only on Enter), with immediate clear when the bar closes or the query is emptied so stale keepPreviousData matches cannot replay under a fresh box.

The find bar now treats Enter / Shift+Enter as match navigation when results match the submitted term; while the typed term is stale or still loading, Enter commits or does nothing instead of stepping through the previous term’s hits. The counter stays mounted with stable width, shows 1 of N (or N+ when truncated), keeps the prior count while loading, and shows a spinner until No results is definitive.

All matching cells get a --highlight-match-bg overlay (active hit still reads via the selection outline). Matches are grouped per row for memoized DataRow updates. Auto-reveal of the first hit runs once per term and is skipped if that row isn’t in the loaded window (avoids serial paging on every typing pause); next/prev and deliberate navigation still use the existing paging path with sequence guards against superseded jumps.

TableFind is memoized; find query cache gcTime is shortened for type-as-you-go. Unit tests cover the bar’s counter and keyboard behavior. Closing find clears term, highlights, and cursor but does not restore the pre-find cell selection (last match / current selection remains, per inline design).

^{Reviewed by Cursor Bugbot for commit 4b884db. Configure here.}

Greptile Summary

The PR makes table find search debounced as users type, highlights all matches, improves counter and navigation states, and clears search state when closed.

• Adds match highlighting and a memoized find bar with clear, loading, count, and accessible input states.
• Coordinates debounced queries, placeholder-result gating, match identity reconciliation, and deferred row loading.
• Adds focused find-bar interaction tests and shortens find-query cache retention.

Confidence Score: 4/5

The PR is not yet safe to merge because a match removed during the final deferred-reveal window can still be selected as a current result.

The reply states that the removed-match issue was fixed, but the current code validates the target only before queueing it; a row invalidation can remove it before the later effect selects it without another membership check.

Files Needing Attention: apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

_{Reviews (12): Last reviewed commit: "fix(tables): skip the reveal when the ta..." | Re-trigger Greptile}

@greptile

@cursor review

@greptile

@cursor review

Fixed the remaining in-flight-jump issue in 0153cd4: a dedicated effect keyed on the submitted term now bumps the jump sequence, nulls the pending match and drops isJumping on every term change — declared above the auto-reveal so it runs first. A jump still paging toward the previous term's match can no longer finish, pass its own sequence check and reveal a cell that no longer matches. Clearing and closing route through the same effect, since both drive the term to empty.

@greptile

@cursor review

@greptile

@cursor review

@cursor review

@greptile

@cursor review

@greptile

@cursor review

@greptile

@cursor review

@greptile

@cursor review